conformance test: tear down manifests before blobs #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdolitsky
requested changes
Jun 5, 2020
There was a problem hiding this comment.
@majewsky please see this issue for some context: #134
I think modifying this order will break the test for most other registries, so I think that either:
- You should set necessary env vars prevent pull setup/teardown (please see https://github.com/opencontainers/distribution-spec/tree/master/conformance#pull)
- This PR should be modified to switch the order based on the presence of some env var
My own registry implementation, Keppel [1] forbids deleting blobs that are still referenced by manifests. To do a proper cleanup in this case, the manifest needs to be deleted first. [1] https://github.com/sapcc/keppel Signed-off-by: Stefan Majewsky <[email protected]>
majewsky
force-pushed
the
better-teardown-order
branch
from
1d786d5
to
567865a
Compare
Done. |
Signed-off-by: Stefan Majewsky <[email protected]>
|
Documentation added. |
jdolitsky
requested changes
Jun 9, 2020
|
@majewsky looks good. Last thing is the DCO check failed on your last commit. Can you amend the commit to contain signoff then we can merge? |
Signed-off-by: Stefan Majewsky <[email protected]>
majewsky
force-pushed
the
better-teardown-order
branch
from
9620234
to
4e45fd3
Compare
jdolitsky
approved these changes
Jun 16, 2020
|
@majewsky - thanks for you patience, looks like the final commit had a different email in signed-off-by which might be causing an error: https://pullapprove.com/opencontainers/distribution-spec/pull-request/156/requirements/ |
|
LGTM |
Merged
mikebrow
added a commit
that referenced
this pull request
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the added comments, "some registries" (i.e. my own implementation, Keppel https://github.com/sapcc/keppel) forbid deleting blobs that are still referenced by manifests. To do a proper cleanup in this case, the manifest needs to be deleted first.
The diff looks a bit weird, but I really just swapped the order of some paragraphs, pulling the manifest deletion to the top.