Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebasing #156 #170

Merged
merged 3 commits into from
Jul 9, 2020
Merged

rebasing #156 #170

merged 3 commits into from
Jul 9, 2020

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Jul 9, 2020

Fixed the DCO emails to match the committer.

closes #156

My own registry implementation, Keppel [1] forbids deleting blobs that
are still referenced by manifests. To do a proper cleanup in this case,
the manifest needs to be deleted first.

[1] https://github.com/sapcc/keppel

Signed-off-by: Stefan Majewsky <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
Signed-off-by: Stefan Majewsky <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
Signed-off-by: Stefan Majewsky <[email protected]>
Signed-off-by: Vincent Batts <[email protected]>
@jdolitsky
Copy link
Member

jdolitsky commented Jul 9, 2020

LGTM

Approved with PullApprove

1 similar comment
@jzelinskie
Copy link
Member

jzelinskie commented Jul 9, 2020

LGTM

Approved with PullApprove

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit a6e5b09 into opencontainers:master Jul 9, 2020
@vbatts vbatts deleted the vbatts/156-dco branch July 10, 2020 20:42
@vbatts vbatts mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants