Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize distribution spec #178

Merged
merged 6 commits into from
Aug 28, 2020
Merged

Reorganize distribution spec #178

merged 6 commits into from
Aug 28, 2020

Conversation

pmengelbert
Copy link
Contributor

  • New spec.md
  • Move 'detail' section into detail.md

To view the revised spec in complete form, see the following:
https://github.com/bloodorangeio/distribution-spec/blob/new-spec/spec.md

@pmengelbert
Reorganize distribution spec
c90b0f1 
* New spec.md
* Move 'detail' section into detail.md

Signed-off-by: Peter Engelbert <[email protected]>
This was referenced Aug 11, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
hallyn
hallyn suggested changes Aug 18, 2020
View reviewed changes
spec.md Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
spec.md Show resolved Hide resolved
@jdolitsky jdolitsky mentioned this pull request Aug 24, 2020
Closed
@pmengelbert pmengelbert mentioned this pull request Aug 24, 2020
Open
@jdolitsky jdolitsky self-requested a review August 24, 2020 18:58
dmcgowan
dmcgowan approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrow
mikebrow reviewed Aug 27, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

spec.md Outdated Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
detail.md Outdated Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
@pmengelbert
Restore and move parts of old spec to new files.
1877628 
* Content Digests section restored to content-addressability.md
* Language clarification in detail.md
* Use Cases section restored to scenarios.md
* Scope section restored to spec.md

Signed-off-by: Peter Engelbert <[email protected]>
@pmengelbert
Add a few small sections
c7125ce 
Signed-off-by: Peter Engelbert <[email protected]>
@pmengelbert
Copy link
Contributor Author

@mikebrow Let me know if all of your concerns have been addressed. Thanks for the review!

@vbatts
Copy link
Member

vbatts commented Aug 28, 2020 •
edited by caniszczyk
Loading

What a monumental effort. The miniupdate branch was the best way to break this rewrite up.
Doing a once-through looks essentially all there.
Thanks @jdolitsky and @pmengelbert for this work.

LGTM

Approved with PullApprove

mikebrow
mikebrow reviewed Aug 28, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits.. and a couple questions.

After those it will probably be best to merge this and move to the line by line review + edits on new PRs. It's just two hard to review massive re-orgs with this tool.

spec.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
scenarios.md Show resolved Hide resolved
spec.md Show resolved Hide resolved
@jdolitsky jdolitsky mentioned this pull request Aug 28, 2020
Closed
@jdolitsky
Copy link
Member

@vbatts - we appreciate this!

@mikebrow opened #181 to link back and forth between the new spec and these other docs (content-addressibility.md etc.)

Like you said, I think it's best to get this merged then follow up with tiny PRs to amend prior to 1.0

@pmengelbert
Add TODO under conformance
22583a5 
Signed-off-by: Peter Engelbert <[email protected]>
mikebrow
mikebrow approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky
Copy link
Member

jdolitsky commented Aug 28, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@mikebrow mikebrow merged commit 2c79ed5 into opencontainers:master Aug 28, 2020
@mikebrow
Copy link
Member

thx guys! tty on monday to begin next phase :-)

@jdolitsky jdolitsky mentioned this pull request Sep 22, 2020
Closed
@vbatts vbatts mentioned this pull request Sep 30, 2020
Merged
@jonjohnsonjr jonjohnsonjr mentioned this pull request Feb 4, 2021
Open
@vbatts vbatts mentioned this pull request Jun 17, 2021
Merged
@corhere corhere mentioned this pull request Jul 20, 2023
Open
@tianon tianon mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@hallyn hallyn hallyn requested changes

@dmcgowan dmcgowan dmcgowan approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmengelbert @vbatts @jdolitsky @mikebrow @dmcgowan @hallyn