-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize distribution spec #178
Conversation
* New spec.md * Move 'detail' section into detail.md Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
* Content Digests section restored to content-addressability.md * Language clarification in detail.md * Use Cases section restored to scenarios.md * Scope section restored to spec.md Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
@mikebrow Let me know if all of your concerns have been addressed. Thanks for the review! |
What a monumental effort. The miniupdate branch was the best way to break this rewrite up. LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple nits.. and a couple questions.
After those it will probably be best to merge this and move to the line by line review + edits on new PRs. It's just two hard to review massive re-orgs with this tool.
Signed-off-by: Peter Engelbert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thx guys! tty on monday to begin next phase :-) |
To view the revised spec in complete form, see the following:
https://github.com/bloodorangeio/distribution-spec/blob/new-spec/spec.md