Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vendor-specific examples and links #50

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

bsatlas
Copy link
Contributor

@bsatlas bsatlas commented Jan 31, 2019

This PR replaces Docker manifest examples with the OCI. format.

Fixes issue #47

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

spec.md Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
spec.md Show resolved Hide resolved
@bsatlas
Copy link
Contributor Author

bsatlas commented Jan 31, 2019

@mikebrow Thanks for looking over my work! When I was working on this last night, I realized that a bunch of external links to moby should be refactored to link to the image spec. I'll mark this as a work-in-progress.

@bsatlas bsatlas changed the title *:Replace vendor-specific examples. [WIP] Replace vendor-specific examples and links Jan 31, 2019
@bsatlas bsatlas changed the title [WIP] Replace vendor-specific examples and links Replace vendor-specific examples and links Feb 13, 2019
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

spec.md Outdated Show resolved Hide resolved
Signed-off-by: Atlas Kerr <[email protected]>

readme: Fix indenting.

Signed-off-by: Atlas Kerr <[email protected]>
@bsatlas
Copy link
Contributor Author

bsatlas commented Mar 12, 2019

@opencontainers/distribution-spec-maintainers PTAL

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@vbatts
Copy link
Member

vbatts commented Mar 13, 2019

LGTM

Approved with PullApprove

@vbatts vbatts merged commit 39fd7ec into opencontainers:master Mar 13, 2019
@vbatts vbatts mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants