updating link to code of conduct in org repository #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
9 tasks
|
LGTM |
mikebrow
reviewed
Feb 27, 2019
| [developercertificate.org]: http://developercertificate.org/ | ||
| [Freenode]: https://freenode.net/ | ||
| [irc-logs]: http://ircbot.wl.linuxfoundation.org/eavesdrop/%23opencontainers/ | ||
| [mailing-list]: https://groups.google.com/a/opencontainers.org/forum/#!forum/dev | ||
| [meeting.ics]: https://github.com/opencontainers/runtime-spec/blob/master/meeting.ics | ||
| [minutes]: http://ircbot.wl.linuxfoundation.org/meetings/opencontainers/ | ||
| [rfc5545]: https://tools.ietf.org/html/rfc5545 | ||
| [security]: https://github.com/opencontainers/org/blob/master/security |
There was a problem hiding this comment.
/s/security/security.md#reporting-security-issues/
There was a problem hiding this comment.
We just decided on the call to rename the code-of-conduct / change its location, so I think we should wait for opencontainers/.github#6 to be approved / merged and then I can update all links here.
| request on GitHub. Instead, disclose the issue responsibly by sending an email | ||
| to [email protected] (which is inhabited only by the maintainers of | ||
| the various OCI projects). | ||
| If you wish to report a security issue, please see the protocol under [security][security]. |
There was a problem hiding this comment.
nit...
/s/see the protocol under [security]/follow the [OCI org security issue reporting procedure]/
dmcgowan
reviewed
Feb 28, 2019
CONTRIBUTING.md
Outdated
| @@ -139,12 +136,13 @@ using your real name (sorry, no pseudonyms or anonymous contributions.) | |||
|
|
|||
| You can add the sign off when creating the git commit via `git commit -s`. | |||
|
|
|||
| [code-of-conduct]: https://github.com/opencontainers/tob/blob/d2f9d68c1332870e40693fe077d311e0742bc73d/code-of-conduct.md | |||
| [code-of-conduct]: https://github.com/opencontainers/org/blob/master/.github/CODE_OF_CONDUCT.md | |||
There was a problem hiding this comment.
This is now at the root https://github.com/opencontainers/org/blob/master/CODE_OF_CONDUCT.md
There was a problem hiding this comment.
Just fixed, per our discussion in the OCI call!
Signed-off-by: Vanessa Sochat <[email protected]>
|
LGTM |
1 similar comment
|
LGTM |
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vanessa Sochat [email protected]
This is the 2/3 pull request to update the link to the code of conduct, moving from tob to the .github folder of org. This repo (unlike runtime-spec) has the link also in the contributing.md.