Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #713: fix(gha): don't crash when branch name matches file name in the repo #714

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Sep 26, 2024

Description

How Has This Been Tested?

GHA

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek jiridanek changed the title Fix #361: gha: don't crash when branch name matches file name in the repo Fix #713: gha: don't crash when branch name matches file name in the repo Sep 26, 2024
@jiridanek jiridanek changed the title Fix #713: gha: don't crash when branch name matches file name in the repo Fix #713: fix(gha): don't crash when branch name matches file name in the repo Sep 26, 2024
@jiridanek jiridanek changed the title Fix #713: fix(gha): don't crash when branch name matches file name in the repo #713: fix(gha): don't crash when branch name matches file name in the repo Sep 26, 2024
@jiridanek jiridanek changed the title #713: fix(gha): don't crash when branch name matches file name in the repo Fix #713: fix(gha): don't crash when branch name matches file name in the repo Sep 26, 2024
@jiridanek jiridanek changed the title Fix #713: fix(gha): don't crash when branch name matches file name in the repo Issue #713: fix(gha): don't crash when branch name matches file name in the repo Sep 26, 2024
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 48d5c50 into opendatahub-io:main Sep 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When PR branch is unfortunately named, it can cause ambiguities in the git commands in GHA actions
2 participants