Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #713: fix(gha): don't crash when branch name matches file name in the repo #714

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Issue #713: fix(gha): don't crash when branch name matches file name in the repo #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/cached-builds/gha_pr_changed_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ def get_github_token() -> str:
def list_changed_files(from_ref: str, to_ref: str) -> list[str]:
logging.debug("Getting list of changed files from git diff")

files = subprocess.check_output(["git", "diff", "--name-only", from_ref, to_ref],
# https://github.com/red-hat-data-services/notebooks/pull/361: add -- in case to_ref matches a file name in the repo
files = subprocess.check_output(["git", "diff", "--name-only", from_ref, to_ref, '--'],
encoding='utf-8').splitlines()

logging.debug(f"Determined {len(files)} changed files: {files[:100]} (..., printing up to 100 files)")
Expand Down