-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-12621] Update the updater github action to the latest branch #716
Conversation
Skipping CI for Draft Pull Request. |
20fe9c4
to
de5b621
Compare
690a5d9
to
33486ce
Compare
This is waiting for this to be merged openshift/release#57392 - then once it's merged, we need to have another build of the 2024b images (let's re-sync to this branch again). |
33486ce
to
18279cb
Compare
Just some formatting so that the code is similar to what is in downstream for easier comparability.
18279cb
to
e81b49f
Compare
Thanks for the excellent work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This updates the digest updater GHA scripts for both regular workbench images and also runtime images.
On top of that, the runtime images GHA script was a bit enhanced and cleaned of a couple of shellcheck warnings (I can put it as a separate PR if it will be preferred).
https://issues.redhat.com/browse/RHOAIENG-12621
How Has This Been Tested?
Started relevant GHA via https://github.com/jstourac/notebooks/actions
Standard workbench images:
Runtime images:
The GHAs failed as we don't have any 2024b builds in https://quay.io/repository/opendatahub/workbench-images?tab=tags&tag=latest --- will re-run once we have some.
Note: one can see results of the openshift-ci jobs here https://prow.ci.openshift.org/?repo=opendatahub-io%2Fnotebooks.
Also, at the moment there is one extra commit in this PR that replaces names images for version N from python-3.9 to python-3.11 because otherwise it would still search for the python-3.9 based images! Version N-1 should be good without this hack. As a result, I plan to incorporate the update for the images as a part of this PR. This hack won't be necessary in the followup updates until we change the python version again.
Merge criteria: