Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-12621] Update the updater github action to the latest branch #716

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Sep 26, 2024

This updates the digest updater GHA scripts for both regular workbench images and also runtime images.

On top of that, the runtime images GHA script was a bit enhanced and cleaned of a couple of shellcheck warnings (I can put it as a separate PR if it will be preferred).

https://issues.redhat.com/browse/RHOAIENG-12621

How Has This Been Tested?

Started relevant GHA via https://github.com/jstourac/notebooks/actions

Standard workbench images:

Runtime images:


The GHAs failed as we don't have any 2024b builds in https://quay.io/repository/opendatahub/workbench-images?tab=tags&tag=latest --- will re-run once we have some.

Note: one can see results of the openshift-ci jobs here https://prow.ci.openshift.org/?repo=opendatahub-io%2Fnotebooks.

Also, at the moment there is one extra commit in this PR that replaces names images for version N from python-3.9 to python-3.11 because otherwise it would still search for the python-3.9 based images! Version N-1 should be good without this hack. As a result, I plan to incorporate the update for the images as a part of this PR. This hack won't be necessary in the followup updates until we change the python version again.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jstourac
Copy link
Member Author

jstourac commented Oct 2, 2024

This is waiting for this to be merged openshift/release#57392 - then once it's merged, we need to have another build of the 2024b images (let's re-sync to this branch again).

@harshad16
Copy link
Member

Thanks for the excellent work.
i will move this from DRAFT to PR.
and use the newly updated changes to update the change.
if anything fails will open a follow PR.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 👍

Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@harshad16 harshad16 merged commit 0d5db3d into opendatahub-io:main Oct 4, 2024
5 of 7 checks passed
@jstourac jstourac deleted the digestUpdaters2024b branch October 5, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants