Some of the build images were missing the YearIndex in the generated tag

[jstourac]

This should fix this for the both notebook repositories we have.

---

I ran into this during my work on the opendatahub-io/notebooks#716. I checked each of our config file we care about with the following command:

yq '.tests[].steps.env.IMAGE_TAG' <filename>

Any null tells us that it is missing expected env. Note that for the main branch, we expect that because there are some special testing jobs that don't build images (7 occurrences of null at the end of the file).

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@jstourac: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-cuda-tensorflow-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-cuda-tensorflow-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-datascience-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-datascience-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-intel-ml-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-intel-ml-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-intel-pyt-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-intel-pyt-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-intel-tf-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-intel-tf-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-minimal-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-minimal-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-pytorch-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-pytorch-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-rocm-pytorch-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-rocm-tensorflow-ubi9-python-3-11-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[jstourac]

@atheo89 @harshad16 please, take a look, thank you!

[jiridanek]

/pj-rehearse auto-ack

[openshift-ci-robot]

@jiridanek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@jstourac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jiridanek]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/config/opendatahub-io/notebooks/OWNERS [jiridanek,jstourac]
• ci-operator/config/red-hat-data-services/notebooks/OWNERS [jiridanek,jstourac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment