Access rights and index dataset without file #2925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quaxsze
changed the title
maudetes
reviewed
Nov 28, 2023
| @@ -488,6 +489,7 @@ def dataset_from_rdf(graph, dataset=None, node=None): | |||
| default_license = dataset.license or License.default() | |||
| dataset_license = rdf_value(d, DCT.license) | |||
| dataset.license = License.guess(dataset_license, *licenses, default=default_license) | |||
| dataset.access_rights = rdf_value(d, DCT.accessRights) | |||
There was a problem hiding this comment.
We should map from and towards the European vocabulary: http://publications.europa.eu/resource/authority/access-right.
quaxsze
changed the title
maudetes
reviewed
May 23, 2024
| @@ -491,6 +492,8 @@ class Dataset(WithMetrics, BadgeMixin, db.Owned, db.Document): | |||
| deleted = db.DateTimeField() | |||
| archived = db.DateTimeField() | |||
|
|
|||
| access_rights = db.StringField(choices=list(ACCESS_RIGHTS), default=DEFAULT_ACCESS_RIGHTS, required=True) | |||
There was a problem hiding this comment.
access_rights is at the Dataset level, may not match with usage and DCAT?
| @@ -45,8 +45,11 @@ class DatasetSearch(ModelSearchAdapter): | |||
|
|
|||
| @classmethod | |||
| def is_indexable(cls, dataset): | |||
There was a problem hiding this comment.
We don't need to modify this anymore, see #2997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix datagouv/data.gouv.fr#1186