This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Re enable config overrides test #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like how clearly you state why this is done the way it is done. Thanks for the follow up issue creation. |
yojs
approved these changes
Sep 17, 2020
vigyasharma
approved these changes
Sep 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
=========================================
Coverage ? 71.86%
Complexity ? 2566
=========================================
Files ? 322
Lines ? 14571
Branches ? 1227
=========================================
Hits ? 10472
Misses ? 3707
Partials ? 392 Continue to review full report at Codecov.
|
khushbr
added a commit
that referenced
this pull request
Sep 30, 2020
commit 240e046 Author: Joydeep Sinha <[email protected]> Date: Thu Sep 24 10:53:01 2020 -0700 Update PULL_REQUEST_TEMPLATE.md commit 5bd53d5 Author: Sruti Parthiban <[email protected]> Date: Wed Sep 23 11:07:02 2020 -0700 Persist published actions in sqlite (#433) * Persist actions in sqlite * Address PR comments commit dfa9c22 Author: Ruizhen Guo <[email protected]> Date: Tue Sep 22 13:05:11 2020 -0700 Fix cache action to handle unbounded fielddata cache (#432) commit f67e668 Author: Ruizhen Guo <[email protected]> Date: Mon Sep 21 14:48:04 2020 -0700 enable JVM decider in graph (#431) commit abc7b12 Author: Vigya Sharma <[email protected]> Date: Fri Sep 18 10:47:44 2020 -0700 Rename config folder to configs (#429) commit 4eadc4e Author: Ruizhen Guo <[email protected]> Date: Fri Sep 18 10:42:53 2020 -0700 Add cache clear action in JVM decider (#428) commit 54e61c5 Author: Karthik Kumarguru <[email protected]> Date: Thu Sep 17 11:33:37 2020 -0700 Re enable config overrides test (#427)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #:
#422
Description of changes:
This change makes the two methods:
updateAllRcaConfsandupdateRcaConfnon static even though they don't mutate any state so that the unit tests for ConfigOverridesApplier can be enabled again.While it is easy to refactor it out into a static helper, mocking static objects is currently not a simple fix in our codebase as PowerMockRunner is not ignoring log4j classes and is causing initialization issues for a lot of classes during unit testing(#426)
This is a simple fix for enabling the tests until #426 is resolved.
Tests:
./gradlew buildBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.