Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Re enable config overrides test #427

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Re enable config overrides test #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...a/com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/framework/core/RcaConf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ public <T> T readRcaConfig(String rcaName, String key, T defaultValue, Predicate
return setting;
}

public static boolean updateAllRcaConfFiles(final Set<String> mutedRcas, final Set<String> mutedDeciders,
public boolean updateAllRcaConfFiles(final Set<String> mutedRcas, final Set<String> mutedDeciders,
final Set<String> mutedActions) {
boolean updateStatus = true;
// update all rca.conf files
Expand All @@ -260,7 +260,7 @@ public static boolean updateAllRcaConfFiles(final Set<String> mutedRcas, final S
return updateStatus;
}

private static boolean updateRcaConf(String originalFilePath, final Set<String> mutedRcas,
private boolean updateRcaConf(String originalFilePath, final Set<String> mutedRcas,
final Set<String> mutedDeciders, final Set<String> mutedActions) {

String updatedPath = originalFilePath + ".updated";
Expand Down
2 changes: 0 additions & 2 deletions ...distro/elasticsearch/performanceanalyzer/config/overrides/ConfigOverridesApplierTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,11 @@
import java.util.List;
import java.util.Set;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.mockito.ArgumentCaptor;
import org.mockito.Captor;
import org.mockito.Mock;

@Ignore
public class ConfigOverridesApplierTest {

private static final String RCA1 = "rca1";
Expand Down