build: add common constraint and run make upgrade
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This replaces #25 |
mraarif
reviewed
Jul 28, 2021
| .PHONY: $(COMMON_CONSTRAINTS_TXT) | ||
| $(COMMON_CONSTRAINTS_TXT): | ||
| wget -O "$(@)" https://raw.githubusercontent.com/edx/edx-lint/master/edx_lint/files/common_constraints.txt || touch "$(@)" | ||
|
|
There was a problem hiding this comment.
Hi, @stvstnfrd I had a question regarding this,
what was the problem that we faced with the previous implementation of using the common_constraints file directly?
or what problem does this (downloading the constraint file to local) solve?
There was a problem hiding this comment.
Hi @mraarif
dependabot (the Github security upgrade PR creator, used across our repos) expects all requirements to be saved locally on disk and fails to fetch requirements files if they're remote.
So using -c https://... breaks the integration and dependabot stops working.
a little more text originally shared here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.