-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add common constraint and run make upgrade
#26
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# A central location for most common version constraints | ||
# (across edx repos) for pip-installation. | ||
# | ||
# Similar to other constraint files this file doesn't install any packages. | ||
# It specifies version constraints that will be applied if a package is needed. | ||
# When pinning something here, please provide an explanation of why it is a good | ||
# idea to pin this package across all edx repos, Ideally, link to other information | ||
# that will help people in the future to remove the pin when possible. | ||
# Writing an issue against the offending project and linking to it here is good. | ||
# | ||
# Note: Changes to this file will automatically be used by other repos, referencing | ||
# this file from Github directly. It does not require packaging in edx-lint. | ||
|
||
|
||
# using LTS django version | ||
Django<2.3 | ||
|
||
# docutils version 0.17 is causing docs rendering to fail | ||
# See https://sourceforge.net/p/docutils/bugs/417/ | ||
docutils==0.16 | ||
|
||
# latest version is causing e2e failures in edx-platform. | ||
drf-jwt<1.19.1 | ||
|
||
# Newer versions causing tests failures in multiple repos. | ||
pyjwt[crypto]==1.7.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @stvstnfrd I had a question regarding this,
what was the problem that we faced with the previous implementation of using the
common_constraints
file directly?or what problem does this (downloading the constraint file to local) solve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mraarif
dependabot (the Github security upgrade PR creator, used across our repos) expects all requirements to be saved locally on disk and fails to fetch requirements files if they're remote.
So using
-c https://...
breaks the integration and dependabot stops working.a little more text originally shared here: