-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: data layer API call for ORA block data #2002
Conversation
Doing this field by field checking to make it work along the way instead of in one big bang.
Added new test block setup for flex grading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple comments
editor_type = CharField(source="text_response_editor") | ||
allow_latex_preview = BooleanField(source="allow_latex") | ||
|
||
def get_enabled(self, block): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there was a simple way to remove this semi-duplicated code across the few serializers but i think doing that would complicate things more than they need to be
Reduce code duplication by creating a custom required field
Previously, used a different name to work around not being able to use "self" reserved keyword. Found this workaround to allow.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2002 +/- ##
==========================================
+ Coverage 94.99% 95.08% +0.09%
==========================================
Files 155 158 +3
Lines 17108 17429 +321
Branches 1616 1626 +10
==========================================
+ Hits 16251 16572 +321
Misses 642 642
Partials 215 215
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, nice tests
When attempting to upgrade |
@nsprenkle maybe add |
This reverts commit 8145367.
* feat: add ORA data layer for ORA MFE * chore: bump version to 5.2.2 --------- Co-authored-by: jansenk <[email protected]>
TL;DR - Add a new endpoint
{{protocol}}://{{lms_url}}/courses/{{course_id}}/xblock/{{block_id}}/handler/get_block_info
to get ORA block info.JIRA: AU-1381
Developer Checklist
Testing Instructions
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora