feat: babel-plugin-react-intl to babel-plugin-formatjs migration #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1200 +/- ##
==========================================
+ Coverage 88.04% 88.09% +0.04%
==========================================
Files 266 266
Lines 4518 4518
Branches 1142 1142
==========================================
+ Hits 3978 3980 +2
+ Misses 526 524 -2
Partials 14 14 ☔ View full report in Codecov by Sentry. |
brian-smith-tcril
approved these changes
Feb 8, 2024
| @@ -66,7 +66,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@edx/browserslist-config": "1.2.0", | |||
| "@edx/frontend-build": "^12.9.10", | |||
| "@edx/frontend-build": "13.0.1", | |||
There was a problem hiding this comment.
might be worth updating this to use the latest version of frontend-build https://github.com/openedx/frontend-build/releases/tag/v13.0.28
There was a problem hiding this comment.
I'm gonna merge these as is to get this change landed, since it's been open since October, and the scope update will require more code changes to webpack config and potentially other files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded to fronted-build v13 which migrates deprecated babel-plugin-react-intl to babel-plugin-formatjs.
Changed
i18n_extractscript inpackage.jsonaccordinglyEpic Link
Migrate off babel-plugin-react-intl in favor of babel-plugin-formatjs