Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off babel-plugin-react-intl in favor of babel-plugin-formatjs #120

Closed
1 task
adamstankiewicz opened this issue Aug 4, 2022 · 5 comments · Fixed by openedx/frontend-build#258
Closed
1 task
Assignees

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Aug 4, 2022

The babel-plugin-react-intl package that @edx/frontend-build uses in its Babel configs is deprecated in favor of babel-plugin-formatjs.

AC

  • Modify @edx/frontend-build to no longer rely on babel-plugin-react-intl in favor of babel-plugin-formatjs.

PRs

@arbrandes
Copy link

@BilalQamar95, just checking: are you working on this? Or should we put it in the backlog for somebody else to pick up?

@BilalQamar95
Copy link

@arbrandes There is a PR for it waiting for review

@arbrandes
Copy link

PR was reviewed, but there are some remaining concerns. In other words, this is still in progress.

@BilalQamar95
Copy link

The PR for it(frontend-build#258) was a breaking change causing translation failures for consumers, reference edx/frontend-component-header-edx#338. Reopening this, since the PR was reverted & migration towards babel-plugin-formatjs in still in progress while we further look into it.

@BilalQamar95 BilalQamar95 reopened this Jan 27, 2023
This was referenced Oct 4, 2023
@arbrandes
Copy link

Looks like we're done here. Thanks for all this work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants