Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: babel-plugin-react-intl to babel-plugin-formatjs migration #855

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

abdullahwaheed
Copy link
Contributor

@abdullahwaheed abdullahwaheed commented Oct 4, 2023

Upgraded to fronted-build v13 which migrates deprecated babel-plugin-react-intl to babel-plugin-formatjs.
Changed i18n_extract script in package.json accordingly

Epic Link

Migrate off babel-plugin-react-intl in favor of babel-plugin-formatjs

@abdullahwaheed abdullahwaheed self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b892ba7) 66.22% compared to head (a2bb70a) 66.22%.

❗ Current head a2bb70a differs from pull request most recent head ffb2cfd. Consider uploading reports for the commit ffb2cfd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #855   +/-   ##
=======================================
  Coverage   66.22%   66.22%           
=======================================
  Files          52       52           
  Lines         823      823           
  Branches      158      158           
=======================================
  Hits          545      545           
  Misses        268      268           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Oct 20, 2023
@jsnwesson jsnwesson merged commit 48d2766 into master Oct 23, 2023
7 checks passed
@jsnwesson jsnwesson deleted the abdullahwaheed/react-intl-to-formatjs branch October 23, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants