Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: babel-plugin-react-intl to babel-plugin-formatjs migration #913

Conversation

abdullahwaheed
Copy link
Contributor

@abdullahwaheed abdullahwaheed commented Oct 4, 2023

Upgraded to fronted-build v13 which migrates deprecated babel-plugin-react-intl to babel-plugin-formatjs.
Changed i18n_extract script in package.json accordingly

Epic Link

Migrate off babel-plugin-react-intl in favor of babel-plugin-formatjs

@abdullahwaheed abdullahwaheed self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1696af) 66.97% compared to head (2682b93) 66.97%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #913   +/-   ##
=======================================
  Coverage   66.97%   66.97%           
=======================================
  Files         128      128           
  Lines        3201     3201           
  Branches      927      927           
=======================================
  Hits         2144     2144           
  Misses       1008     1008           
  Partials       49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though CI is green, once the push and pull translations run, that would make it clear if the change is working as expected.

@abdullahwaheed
Copy link
Contributor Author

@DawoudSheraz is this PR ready to merge?

@DawoudSheraz DawoudSheraz merged commit a33966b into openedx:master Nov 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants