-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: JS translation missing locale
directory
#326
fix: JS translation missing locale
directory
#326
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
1 similar comment
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
463ffe6
to
3461ce8
Compare
Thanks for the contribution, @shadinaif! Please let us know when it's ready for review. |
3461ce8
to
2e354c0
Compare
Thank you @itsjeyd , it is ready. Just forgot to mention that 😅 . I've rebased on master a moment ago |
@shadinaif, ack. I'll review this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadinaif, we don't need to update the version here, but please add the following section to Changelog.md
:
Unreleased
----------
* <description of this change>
We removed `locale` symbolic link but forgot to set it manually in settings.py JS compilation for translations will not find source translation files without this fix Refs: FC-0012 OEP-58
cbc484a
to
97398af
Compare
Thanks for your review @Agrendalath . Please check my replies above |
5091f0f
to
0d5247b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that the translations CI is passing
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository: n/a
tail can produce duplicate messages in djang.po which will raise an error in compilemessages Refs: FC-0012 OEP-58
0d5247b
to
d7d2eb0
Compare
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
We removed
locale
symbolic link but forgot to set it manually in settings.py JS compilation for translations will not find source translation files without this fixThis is still needed until we remove all local translations at the end of the project. Otherwise,
make compile_translations
will empty out all JS translations inpublic/js/translations
directoryThe PR also fixes
make extract_translations
to usemsgcat
instead oftail
Related to work done in #316
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks