-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make extract_translations #371
fix: make extract_translations #371
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 77 77
Lines 6371 6371
=======================================
Hits 6228 6228
Misses 143 143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d344ecc
to
4143e5b
Compare
It seems this is following the same pattern as openedx/xblock-drag-and-drop-v2#326 Once the requested changes on that one have been made this should be updated to match the approved pattern. I'm marking this as "blocked by other work" for now |
7df65a1
to
10c174e
Compare
Done @brian-smith-tcril |
Hi @shadinaif @brian-smith-tcril - is this ready for review? |
@mphilbrick211 yes it is! According to the spreadsheet a review is required from @MichaelRoytman |
Translation directories are not ignored by i18n which make them included in the extraction process Refs: FC-0012 OEP-58
tail can produce duplicate messages in django.po which will raise an error in compilemessages Refs: FC-0012 OEP-58
10c174e
to
67d1c45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the delay. I was on PTO. Thank you for your patience.
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
ignore_dirs
. JS text extraction is failing because it re-reads its ownpublic/js/translations
directory. Related to work done in feat: support JS i18n #360make extract_translations
to usemsgcat
instead oftail
. Related to work done in feat: standardize translation directory for i18n_tool #341References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks