This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix to_pod storage trie value decoding #10368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
added
A0-pleasereview 🤓
5chdn
added
B1-patch-beta 🕷🕷
B0-patch-stable 🕷
ascjones
approved these changes
Feb 18, 2019
ascjones
added
A8-looksgood 🦄
cheme
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
Thanks for spotting this (I wrote the original line), it is clearly correct to use the rlp decoder and more future proof.
I think it will make thing panic only in case of encoding change (u256 are aligned so encoded as a Vec, maybe there is a corner case I am not thinking about).
HCastano
pushed a commit
to HCastano/parity-ethereum
that referenced
this pull request
Feb 25, 2019
HCastano
pushed a commit
to HCastano/parity-ethereum
that referenced
this pull request
Feb 25, 2019
HCastano
added a commit
that referenced
this pull request
Feb 25, 2019
* no-git for publish jobs, empty artifacts dir (#10393) * no-git for publish jobs, empty artifacts dir * fix syntax * prettiness * fix prettiness * should get rid of git in publishing * snap: reenable i386, arm64, armhf architecture publishing (#10386) * snap: reenable i386, arm64, armhf architecture publishing * gitlab: fix indent * gitlab: fix yml syntax * Linker for crosscomile * fix target to linker * new docker image * fix lint, add build to this PR * calc SHA3 using rhash * add new images for i386, armhf * show snap target & artifacts * set CARGO_TARGET for publish snap * move detect Version to publish snap * rm libc6 dep from snap-template up pub-snap script * clean up cargo config before add linker * move linker config to docker images * tx pool: always accept local transactions (#10375) * tx pool: always accept local transactions * tx pool: `choose` local txs with same sender and nonce * Fix to_pod storage trie value decoding (#10368)
HCastano
added a commit
that referenced
this pull request
Feb 25, 2019
* no-git for publish jobs, empty artifacts dir (#10393) * no-git for publish jobs, empty artifacts dir * fix syntax * prettiness * fix prettiness * should get rid of git in publishing * Fix to_pod storage trie value decoding (#10368) * snap: reenable i386, arm64, armhf architecture publishing (#10386) * snap: reenable i386, arm64, armhf architecture publishing * gitlab: fix indent * gitlab: fix yml syntax * Linker for crosscomile * fix target to linker * new docker image * fix lint, add build to this PR * calc SHA3 using rhash * add new images for i386, armhf * show snap target & artifacts * set CARGO_TARGET for publish snap * move detect Version to publish snap * rm libc6 dep from snap-template up pub-snap script * clean up cargo config before add linker * move linker config to docker images
ordian
added a commit
that referenced
this pull request
Apr 5, 2019
* master: fix #10390 (#10391) Fix to_pod storage trie value decoding (#10368) revert some changes, could be buggy (#10399) version: bump nightly to 2.5 (#10392) no-git for publish jobs, empty artifacts dir (#10393) fix(jni): bump to jni to 0.11 & remove unsafe impl (#10394) chore(bump ethereum-types) (#10396) Update to latest mem-db, hash-db and trie-db. (#10314) tx pool: always accept local transactions (#10375)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current decoding method is not correct, which will make things panic.