Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

revert some changes, could be buggy #10399

Merged
merged 8 commits into from
Feb 21, 2019
Merged

revert some changes, could be buggy #10399

merged 8 commits into from
Feb 21, 2019

Conversation

TriplEight
Copy link
Collaborator

No description provided.

@parity-cla-bot
Copy link

It looks like @TriplEight signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@TriplEight TriplEight merged commit 4311d43 into master Feb 21, 2019
@soc1c soc1c deleted the fix-ci_307 branch February 25, 2019 14:34
@@ -99,7 +99,7 @@ build-windows:
publish-docker:
stage: publish
only: *releaseable_branches
<<: *no_git
# <<: *no_git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove it or not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@@ -140,23 +140,6 @@ publish-onchain:
tags:
- linux-docker

# configures aws for fast uploads/syncs
.s3-before-script: &s3-before-script
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this being removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to docker parity/awscli @TriplEight ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's here now

HCastano pushed a commit to HCastano/parity-ethereum that referenced this pull request Feb 27, 2019
HCastano pushed a commit to HCastano/parity-ethereum that referenced this pull request Feb 27, 2019
@soc1c soc1c added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. A6-revertrevert 💀 Pull request that reverts recent changes. labels Feb 27, 2019
@soc1c soc1c added this to the 2.5 milestone Feb 27, 2019
@soc1c soc1c added B1-patch-beta 🕷🕷 M1-ci 🙉 Continuous integration. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Feb 27, 2019
HCastano added a commit that referenced this pull request Feb 27, 2019
* revert some changes, could be buggy (#10399)

* ci: clean up gitlab-ci.yml leftovers from previous merge (#10429)

* 10000 > 5000 (#10422)

addresses #10418

* fix underflow in pip, closes #10419 (#10423)

* fix panic when logging directory does not exist, closes #10420 (#10424)

* Update hardcoded headers for Foundation, Ropsten, Kovan and Classic (#10417)

* update foundation to #7262209

* update kovan to #10434561

* update ropsten to #5027841

* update classic to #7555073

* Update Ropsten headers to #5101569
HCastano added a commit that referenced this pull request Feb 27, 2019
* revert some changes, could be buggy (#10399)

* 10000 > 5000 (#10422)

addresses #10418

* fix panic when logging directory does not exist, closes #10420 (#10424)

* fix underflow in pip, closes #10419 (#10423)

* ci: clean up gitlab-ci.yml leftovers from previous merge (#10429)

* Update hardcoded headers for Foundation, Ropsten, Kovan and Classic (#10417)

* update foundation to #7262209

* update kovan to #10434561

* update ropsten to #5027841

* update classic to #7555073

* Update Ropsten headers to #5101569
ordian added a commit that referenced this pull request Apr 5, 2019
* master:
  fix #10390 (#10391)
  Fix to_pod storage trie value decoding (#10368)
  revert some changes, could be buggy (#10399)
  version: bump nightly to 2.5 (#10392)
  no-git for publish jobs, empty artifacts dir (#10393)
  fix(jni): bump to jni to 0.11 & remove unsafe impl (#10394)
  chore(bump ethereum-types) (#10396)
  Update to latest mem-db, hash-db and trie-db. (#10314)
  tx pool: always accept local transactions (#10375)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. A6-revertrevert 💀 Pull request that reverts recent changes. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M1-ci 🙉 Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants