Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Stop breaking out of loop if a non-canonical hash is found #10729

Merged
merged 9 commits into from
Jun 10, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented Jun 10, 2019

Re-opens #10566

ref. #10085

@dvdplm dvdplm requested review from rphmeier, tomusdrw and seunlanlege and removed request for rphmeier June 10, 2019 10:30
@dvdplm dvdplm self-assigned this Jun 10, 2019
@dvdplm dvdplm added the A0-pleasereview 🤓 Pull request needs code review. label Jun 10, 2019
@tomusdrw
Copy link
Collaborator

@lazaridiscom can you elaborate what you mean? This fixes a lookup of canonical epoch on non-canonical chains that are longer than the current canon chain.

As you've seen when you analyzed #10085 (thanks a lot for your input!) currently we see such long non-canonical chains produced on AuRa.

However, the issue in general is that it should happen really rarely, and the fact that we can't recover from this situation is only partially related to the fix in this PR.

What happens with chains in #10085 is that we see two forks that both reach finality and the never re-organize between one and the other - that should never happen in the first place and we're working on a fix.

@dvdplm dvdplm merged commit 5da8da6 into master Jun 10, 2019
@seunlanlege seunlanlege deleted the dp/hc-non-canon-block-logging branch June 10, 2019 17:01
dvdplm added a commit that referenced this pull request Jun 10, 2019
…-even

* master:
  Stop breaking out of loop if a non-canonical hash is found (#10729)
  Refactor Clique stepping (#10691)
dvdplm added a commit that referenced this pull request Jun 10, 2019
…anager

* master:
  Stop breaking out of loop if a non-canonical hash is found (#10729)
  Refactor Clique stepping (#10691)
dvdplm added a commit that referenced this pull request Jun 17, 2019
* master:
  updater: fix static id hashes initialization (#10755)
  Use fewer threads for snapshotting (#10752)
  Die error_chain, die (#10747)
  Fix deprectation warnings on nightly (#10746)
  fix docker tags for publishing (#10741)
  DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705)
  ethcore: enable ECIP-1054 for classic (#10731)
  Stop breaking out of loop if a non-canonical hash is found (#10729)
  Refactor Clique stepping (#10691)
  Use RUSTFLAGS to set the optimization level (#10719)
  SecretStore: non-blocking wait of session completion (#10303)
  removed secret_store folder (#10722)
  SecretStore: expose restore_key_public in HTTP API (#10241)
  Revert "enable lto for release builds (#10717)" (#10721)
  enable lto for release builds (#10717)
  Merge `Notifier` and `TransactionsPoolNotifier` (#10591)
dvdplm added a commit that referenced this pull request Jun 18, 2019
* master:
  Enable aesni (#10756)
  remove support of old SS db formats (#10757)
  [devp2p] Don't use `rust-crypto` (#10714)
  updater: fix static id hashes initialization (#10755)
  Use fewer threads for snapshotting (#10752)
  Die error_chain, die (#10747)
  Fix deprectation warnings on nightly (#10746)
  fix docker tags for publishing (#10741)
  DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705)
  ethcore: enable ECIP-1054 for classic (#10731)
  Stop breaking out of loop if a non-canonical hash is found (#10729)
  Refactor Clique stepping (#10691)
  Use RUSTFLAGS to set the optimization level (#10719)
  SecretStore: non-blocking wait of session completion (#10303)
  removed secret_store folder (#10722)
  SecretStore: expose restore_key_public in HTTP API (#10241)
  Revert "enable lto for release builds (#10717)" (#10721)
  enable lto for release builds (#10717)
  Merge `Notifier` and `TransactionsPoolNotifier` (#10591)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants