Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Print warnings when using dangerous settings for ValidatorSet #10733

Merged
merged 19 commits into from
Jun 24, 2019

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented Jun 10, 2019

AuRa should not be used with a single validator or with an even number. Print appropriate warnings.

ref. #10085

@dvdplm dvdplm self-assigned this Jun 10, 2019
@dvdplm dvdplm requested a review from tomusdrw June 10, 2019 13:52
@dvdplm dvdplm added the A0-pleasereview 🤓 Pull request needs code review. label Jun 10, 2019
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions.

ethcore/src/engines/authority_round/finality.rs Outdated Show resolved Hide resolved
ethcore/src/engines/validator_set/simple_list.rs Outdated Show resolved Hide resolved
ethcore/src/engines/validator_set/simple_list.rs Outdated Show resolved Hide resolved
ethcore/blockchain/src/blockchain.rs Outdated Show resolved Hide resolved
ethcore/blockchain/src/blockchain.rs Outdated Show resolved Hide resolved
ethcore/blockchain/src/blockchain.rs Outdated Show resolved Hide resolved
ethcore/blockchain/src/blockchain.rs Outdated Show resolved Hide resolved
dvdplm and others added 4 commits June 10, 2019 18:51
…hub.com:paritytech/parity-ethereum into dp/chore/aura-warn-when-validators-is-1-or-even

* 'dp/chore/aura-warn-when-validators-is-1-or-even' of github.com:paritytech/parity-ethereum:
  Update ethcore/blockchain/src/blockchain.rs
…-even

* master:
  Stop breaking out of loop if a non-canonical hash is found (#10729)
  Refactor Clique stepping (#10691)
@dvdplm dvdplm requested a review from tomusdrw June 13, 2019 15:03
…-even

* master:
  [devp2p] Update to 2018 edition (#10716)
  Add a way to signal shutdown to snapshotting threads (#10744)
  Enable aesni (#10756)
  remove support of old SS db formats (#10757)
  [devp2p] Don't use `rust-crypto` (#10714)
  updater: fix static id hashes initialization (#10755)
  Use fewer threads for snapshotting (#10752)
  Die error_chain, die (#10747)
  Fix deprectation warnings on nightly (#10746)
  fix docker tags for publishing (#10741)
  DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705)
  ethcore: enable ECIP-1054 for classic (#10731)
@ordian ordian removed the A0-pleasereview 🤓 Pull request needs code review. label Jun 21, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. labels Jun 21, 2019
@ordian ordian added this to the 2.6 milestone Jun 21, 2019
@dvdplm dvdplm merged commit f2dd032 into master Jun 24, 2019
@dvdplm dvdplm deleted the dp/chore/aura-warn-when-validators-is-1-or-even branch June 24, 2019 12:50
dvdplm added a commit that referenced this pull request Jun 24, 2019
…anager

* master:
  Print warnings when using dangerous settings for ValidatorSet (#10733)
  ethcore/res: activate atlantis classic hf on block 8772000 (#10766)
  refactor: Fix indentation (#10740)
  Updated Bn128PairingImpl to use optimized batch pairing  (#10765)
  fix: aura don't add `SystemTime::now()` (#10720)
  Initialize private tx logger only if private tx functionality is enabled (#10758)
  Remove unused code (#10762)
  Remove calls to heapsize (#10432)
dvdplm added a commit that referenced this pull request Jun 25, 2019
…dp/fix/prevent-building-block-on-top-of-same-parent

* dp/chore/aura-log-validator-set-in-epoch-manager:
  remove dead code
  Treat empty account the same as non-exist accounts in EIP-1052 (#10775)
  docs: Update Readme with TOC, Contributor Guideline. Update Cargo package descriptions (#10652)
  cleanup
  On second thought non-validators are allowed to report
  Move Engine::register_client to be before other I/O handler registration (#10767)
  cleanup
  Print warnings when using dangerous settings for ValidatorSet (#10733)
  ethcore/res: activate atlantis classic hf on block 8772000 (#10766)
  refactor: Fix indentation (#10740)
  Updated Bn128PairingImpl to use optimized batch pairing  (#10765)
  fix: aura don't add `SystemTime::now()` (#10720)
  Initialize private tx logger only if private tx functionality is enabled (#10758)
  Remove unused code (#10762)
  Remove calls to heapsize (#10432)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants