EIP 191 #9701

seunlanlege · 2018-10-04T11:17:28Z

implemented EIP-191 signing (personal_sign191)

parity-cla-bot · 2018-10-04T11:17:31Z

It looks like this contributor signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

5chdn · 2018-10-26T11:31:11Z

please rebase on master @seunlanlege

please review this well

seunlanlege · 2018-10-26T12:16:16Z

actually this depends on #9631

tomusdrw · 2018-10-29T21:56:38Z

Unreviewable in current state, we need to get #9631 merged first.

ordian · 2018-10-31T13:06:21Z

please rebase on master

5chdn · 2018-11-01T10:33:56Z

#9631 is merged, please rebase

seunlanlege · 2018-11-01T11:32:16Z

done

5chdn · 2018-11-01T11:55:43Z

does not compile

seunlanlege · 2018-11-01T12:37:31Z

rebase went wrong, fixed it now

ordian

looks good, but adding docs and tests never hurts :)

rpc/src/v1/impls/personal.rs

ordian · 2018-11-01T15:26:58Z

rpc/src/v1/types/eip191.rs

+use serde::de;
+use v1::types::{H160, Bytes};
+
+pub enum EIP191Version {


Please document all public types/fields/functions

missing docs for variants

rpc/src/v1/helpers/eip191.rs

Tbaut · 2018-11-01T17:55:50Z

Can you please add the function to the jsonrpc repo just like with eip712?

…dded tests for sign191

tomusdrw

Looks good! What standard this method corresponds to?
It seems that here: https://github.com/ethereum/go-ethereum/pull/17789/files we have a different approach (it uses stringy content-type instead of versions as hex).

tomusdrw · 2018-11-13T14:39:08Z

rpc/src/v1/types/confirmations.rs

+	fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+		write!(
+			f,
+			"sign 0x{} with {}",


Should we change the previous implementation to distinguish between eip191 and this?

tomusdrw · 2018-11-13T14:40:11Z

rpc/src/v1/types/eip191.rs

+use serde::de;
+use v1::types::{H160, Bytes};
+
+pub enum EIP191Version {


missing docs for variants

seunlanlege · 2018-11-13T21:18:04Z

@tomusdrw

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-191.md

* added sign_191 rpc method * fixed hash_structured_data return type * added ConfirmationPayload::SignMessage for non-prefixed signatures, added tests for sign191 * renamed WithValidator -> PresignedTransaction * rename applicationData to data in test * adds docs for EIP191Version, renamed SignRequest to EIP191SignRequest

andresilva · 2018-11-14T11:28:21Z

Is personal_sign191 the method name other implementations are going to use? I couldn't find anything on it.

seunlanlege · 2018-11-14T11:55:31Z

Is personal_sign191 the method name other implementations are going to use? I couldn't find anything on it.

In clef, it's currently implemented as signData,

https://github.com/ethereum/go-ethereum/pull/17789/files#diff-f8316f6ee7e75303007a55a1cde29245R50

* Bump beta to version 2.2.1 * fix: Intermittent failing CI due to addr in use (#9885) Allow OS to set port at runtime * Use Weak reference in PubSubClient (#9886) * Fix json tracer overflow (#9873) * Fix json tracer overflow * Replace trace_executed with a direct trace push * Remove unused variable * Add test for 5a51 * Remove duplicate json! * Fix docker script (#9854) * Dockerfile: change source path of the newly added check_sync.sh (#9869) * Allow to seal work on latest block (#9876) * Allow to seal work on latest block. * Test from @todr to check sealing conditions. * gitlab-ci: make android release build succeed (#9743) * use docker cargo config file for android builds * make android build succeed * ethcore: use Machine::verify_transaction on parent block (#9900) * ethcore: use Machine::verify_transaction on parent block also fixes off-by-one activation of transaction permission contract * ethcore: clarify call to verify_transaction * foundation: #6692865, ropsten: #4417537, kovan: #9363457 * Remove rust-toolchain file (#9906) * EIP-712 implementation (#9631) * EIP-712 impl * added more tests * removed size parsing unwrap * corrected TYPE_REGEX to disallow zero sized fixed length arrays, replaced LinkedHashSet with IndexSet, added API spec to docs, fixed Type::Byte encoding branch * use Option<u64> instead of u64 for Type::Array::Length * replace `.iter()` with `.values()` Co-Authored-By: seunlanlege <[email protected]> * tabify eip712.rs * use proper comments for docs * Cargo.lock: revert unrelated changes * tabify encode.rs * EIP 191 (#9701) * added sign_191 rpc method * fixed hash_structured_data return type * added ConfirmationPayload::SignMessage for non-prefixed signatures, added tests for sign191 * renamed WithValidator -> PresignedTransaction * rename applicationData to data in test * adds docs for EIP191Version, renamed SignRequest to EIP191SignRequest * light-fetch: Differentiate between out-of-gas/manual throw and use required gas from response on failure (#9824) * fix start_gas, handle OOG exceptions & NotEnoughGas * Change START_GAS: 50_000 -> 60_000 * When the `OutOfGas exception` is received then try to double the gas until it succeeds or block gas limit is reached * When `NotEnoughBasGas error` is received then use the required gas provided in the response * fix(light-fetch): ensure block_gas_limit is tried Try the `block_gas_limit` before regard the execution as an error * Update rpc/src/v1/helpers/light_fetch.rs Co-Authored-By: niklasad1 <[email protected]> * simplify cargo audit * Use block header for building finality (#9914) * ci: nuke the gitlab caches (#9855)

sorpaas added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Oct 5, 2018

sorpaas added this to the 2.2 milestone Oct 5, 2018

seunlanlege force-pushed the EIP-191 branch from 05526ca to 62b6d77 Compare October 8, 2018 13:38

5chdn requested review from tomusdrw and andresilva and removed request for tomusdrw October 26, 2018 11:30

5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018

seunlanlege force-pushed the EIP-191 branch from 62b6d77 to 286f477 Compare November 1, 2018 11:24

added sign_191 rpc method

bec576e

seunlanlege force-pushed the EIP-191 branch from 286f477 to bec576e Compare November 1, 2018 11:30

fixed hash_structured_data return type

2d9c30e

ordian approved these changes Nov 1, 2018

View reviewed changes

ordian added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 1, 2018

added ConfirmationPayload::SignMessage for non-prefixed signatures, a…

7eebaf4

…dded tests for sign191

seunlanlege force-pushed the EIP-191 branch from 7cb5f30 to 7eebaf4 Compare November 2, 2018 14:47

seunlanlege added 2 commits November 5, 2018 22:00

renamed WithValidator -> PresignedTransaction

43afedb

rename applicationData to data in test

9c2d101

ordian added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Nov 7, 2018

ordian requested a review from tomusdrw November 13, 2018 14:21

tomusdrw approved these changes Nov 13, 2018

View reviewed changes

adds docs for EIP191Version, renamed SignRequest to EIP191SignRequest

902aca8

seunlanlege merged commit a8617e2 into master Nov 14, 2018

seunlanlege deleted the EIP-191 branch November 14, 2018 08:02

This was referenced Nov 14, 2018

Backport Beta 2.2.1 #9905

Merged

Backport Stable 2.1.6 #9904

Merged

Tbaut added A8-looksgood 🦄 Pull request is reviewed well. B1-patch-beta 🕷🕷 and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 14, 2018

Tbaut mentioned this pull request Nov 14, 2018

Implement EIP-191 Signing API #9422

Closed

tomusdrw mentioned this pull request Nov 15, 2018

Add experimental RPCs flag #9928

Merged

5chdn added the B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. label Nov 26, 2018

tuxxy mentioned this pull request Feb 12, 2019

Implement recently added signing standards from Parity and Geth ethereum/web3.py#1241

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP 191 #9701

EIP 191 #9701

seunlanlege commented Oct 4, 2018

parity-cla-bot commented Oct 4, 2018

5chdn commented Oct 26, 2018

seunlanlege commented Oct 26, 2018

tomusdrw commented Oct 29, 2018

ordian commented Oct 31, 2018

5chdn commented Nov 1, 2018

seunlanlege commented Nov 1, 2018

5chdn commented Nov 1, 2018

seunlanlege commented Nov 1, 2018

ordian left a comment

ordian Nov 1, 2018

tomusdrw Nov 13, 2018

Tbaut commented Nov 1, 2018

tomusdrw left a comment

tomusdrw Nov 13, 2018

tomusdrw Nov 13, 2018

seunlanlege commented Nov 13, 2018

andresilva commented Nov 14, 2018

seunlanlege commented Nov 14, 2018

EIP 191 #9701

EIP 191 #9701

Conversation

seunlanlege commented Oct 4, 2018

parity-cla-bot commented Oct 4, 2018

5chdn commented Oct 26, 2018

seunlanlege commented Oct 26, 2018

tomusdrw commented Oct 29, 2018

ordian commented Oct 31, 2018

5chdn commented Nov 1, 2018

seunlanlege commented Nov 1, 2018

5chdn commented Nov 1, 2018

seunlanlege commented Nov 1, 2018

ordian left a comment

Choose a reason for hiding this comment

ordian Nov 1, 2018

Choose a reason for hiding this comment

tomusdrw Nov 13, 2018

Choose a reason for hiding this comment

Tbaut commented Nov 1, 2018

tomusdrw left a comment

Choose a reason for hiding this comment

tomusdrw Nov 13, 2018

Choose a reason for hiding this comment

tomusdrw Nov 13, 2018

Choose a reason for hiding this comment

seunlanlege commented Nov 13, 2018

andresilva commented Nov 14, 2018

seunlanlege commented Nov 14, 2018