This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Backport Beta 2.2.1 #9905
Merged
Backport Beta 2.2.1 #9905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tbaut
commented
Nov 13, 2018
•
Tbaut
commented
- bump version to 2.2.1
- fix: Intermittent failing CI due to addr in use fix: Intermittent failing CI due to addr in use #9885
- Fix Parity not closing on Ctrl-C Fix Parity not closing on Ctrl-C #9886
- Fix json tracer overflow Fix json tracer overflow #9873
- Fix docker script Fix docker script #9854
- Add hardcoded headers for light client Update hardcoded headers #9907
- gitlab-ci: make android release build succeed gitlab-ci: make android release build succeed #9743
- Allow to seal work on latest block Allow to seal work on latest block #9876
- Remove rust-toolchain file Remove rust-toolchain file #9906
- light-fetch: Differentiate between out-of-gas/manual throw and use required gas from response on failure light-fetch: Differentiate between out-of-gas/manual throw and use required gas from response on failure #9824
- EIP-712 EIP-712 implementation #9631
- EIP-191 EIP 191 #9701
- simplify cargo audit simplify cargo audit #9918
- Fix performance issue importing Kovan blocks Fix performance issue importing Kovan blocks #9914
- ci: nuke the gitlab caches ci: nuke the gitlab caches #9855
Tbaut
added
A8-backport 🕸
Allow OS to set port at runtime
* Fix json tracer overflow * Replace trace_executed with a direct trace push * Remove unused variable * Add test for 5a51 * Remove duplicate json!
* Dockerfile: change source path of the newly added check_sync.sh (#9869)
* Allow to seal work on latest block. * Test from @todr to check sealing conditions.
* use docker cargo config file for android builds * make android build succeed
* ethcore: use Machine::verify_transaction on parent block also fixes off-by-one activation of transaction permission contract * ethcore: clarify call to verify_transaction
ascjones
approved these changes
Nov 13, 2018
sorpaas
approved these changes
Nov 13, 2018
* EIP-712 impl * added more tests * removed size parsing unwrap * corrected TYPE_REGEX to disallow zero sized fixed length arrays, replaced LinkedHashSet with IndexSet, added API spec to docs, fixed Type::Byte encoding branch * use Option<u64> instead of u64 for Type::Array::Length * replace `.iter()` with `.values()` Co-Authored-By: seunlanlege <[email protected]> * tabify eip712.rs * use proper comments for docs * Cargo.lock: revert unrelated changes * tabify encode.rs
* added sign_191 rpc method * fixed hash_structured_data return type * added ConfirmationPayload::SignMessage for non-prefixed signatures, added tests for sign191 * renamed WithValidator -> PresignedTransaction * rename applicationData to data in test * adds docs for EIP191Version, renamed SignRequest to EIP191SignRequest
…quired gas from response on failure (#9824) * fix start_gas, handle OOG exceptions & NotEnoughGas * Change START_GAS: 50_000 -> 60_000 * When the `OutOfGas exception` is received then try to double the gas until it succeeds or block gas limit is reached * When `NotEnoughBasGas error` is received then use the required gas provided in the response * fix(light-fetch): ensure block_gas_limit is tried Try the `block_gas_limit` before regard the execution as an error * Update rpc/src/v1/helpers/light_fetch.rs Co-Authored-By: niklasad1 <[email protected]>
Will go without cache. Meanwhile have to investigate what was wrong and how to use it effectively.
5chdn
added
A8-looksgood 🦄
|
Good work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.