Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): don't throw IndexOutOfBounds exceptions when calling write with null reads and writes #58

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

jimmyjames
Copy link
Contributor

@jimmyjames jimmyjames commented Feb 27, 2024

Description

Don't fail with an IndexOutOfBounds exceptions when calling write with null reads and writes.

Also includes some chores (all in separate commits):

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jimmyjames jimmyjames requested a review from a team as a code owner February 27, 2024 21:46
@jimmyjames jimmyjames changed the title (fix) - don't throw IndexOutOfBounds exceptions when calling write with null reads and writes fix(client) - don't throw IndexOutOfBounds exceptions when calling write with null reads and writes Feb 27, 2024
@jimmyjames jimmyjames changed the title fix(client) - don't throw IndexOutOfBounds exceptions when calling write with null reads and writes fix(client): don't throw IndexOutOfBounds exceptions when calling write with null reads and writes Feb 27, 2024
@rhamzeh rhamzeh added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit f142542 Feb 27, 2024
19 checks passed
@rhamzeh rhamzeh deleted the java-sdk-update branch February 27, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants