Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add note about initializing the OpenFgaClient only once #312

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Feb 20, 2024

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh requested a review from a team as a code owner February 20, 2024 22:14
@ewanharris ewanharris added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit f63f2de Feb 21, 2024
13 checks passed
@ewanharris ewanharris deleted the chore/add-note-about-initializing-client-once branch February 21, 2024 09:54
jimmyjames added a commit to openfga/java-sdk that referenced this pull request Feb 27, 2024
jimmyjames added a commit to openfga/java-sdk that referenced this pull request Feb 27, 2024
github-merge-queue bot pushed a commit to openfga/dotnet-sdk that referenced this pull request Feb 28, 2024
<!-- Thanks for opening a PR! Here are some quick tips:
If this is your first time contributing, [read our Contributing
Guidelines](https://github.com/openfga/.github/blob/main/CONTRIBUTING.md)
to learn how to create an acceptable PR for this repo.
By submitting a PR to this repository, you agree to the terms within the
[OpenFGA Code of
Conduct](https://github.com/openfga/.github/blob/main/CODE_OF_CONDUCT.md)

If your PR is under active development, please submit it as a "draft".
Once it's ready, open it up for review.
-->

<!-- Provide a brief summary of the changes -->

## Description
<!-- Provide a detailed description of the changes -->

- chore: update community links from discord to slack
(openfga/sdk-generator#318)
- chore: document only single OpenFgaClient should be created
(openfga/sdk-generator#312)
- chore: improve issue templates
(openfga/sdk-generator#315)

## References
<!-- Provide a list of any applicable references here (Github Issue,
[OpenFGA RFC](https://github.com/openfga/rfcs), other PRs, etc..) -->

## Review Checklist
- [x] I have clicked on ["allow edits by
maintainers"](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork).
- [ ] I have added documentation for new/changed functionality in this
PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev)
[Provide a link to any relevant PRs in the references section above]
- [x] The correct base branch is being used, if not `main`
- [x] I have added tests to validate that the change in functionality is
working as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants