Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigating to the 2nd page of contributors is broken #3850

Closed
teolemon opened this issue Jul 15, 2020 · 6 comments · Fixed by #9447
Closed

Navigating to the 2nd page of contributors is broken #3850

teolemon opened this issue Jul 15, 2020 · 6 comments · Fixed by #9447
Labels
brokenlinks Those are 404 errors spotted in production. 🐛 bug This is a bug, not a feature request. facets facets allow you to explore products according to various criterion. Based on MongoDB non tech 🎯 P1 pagination Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. ⏲️ 5 minute fix

Comments

@teolemon
Copy link
Member

teolemon commented Jul 15, 2020 •
edited
Loading

What

Code pointer

<ul id="pages" class="pagination"><li class="unavailable">Pages:</li><li class="current"><a href="">1</a></li><li><a href="/contributors/users/2">2</a></li><li><a href="/contributors/users/2" rel="next$nofollow">Next</a></li></ul>

Screenshot

Still in production with the redesign (Nov 2022)

Image

Part of
@teolemon teolemon added the 🐛 bug This is a bug, not a feature request. label Jul 15, 2020
@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 14, 2021
@jolesh
Copy link
Contributor

jolesh commented Jan 14, 2021

Yes the link doesn't work, where have you found it?

@Ban3
Copy link
Contributor

Ban3 commented Jan 14, 2021

@jolesh https://world.openfoodfacts.org/contributors You can get there from homepage by selecting Contributors from Explore products by...

@github-actions github-actions bot removed the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 15, 2021
@jolesh
Copy link
Contributor

jolesh commented Jan 15, 2021

Ah thanks, found it

@teolemon teolemon added brokenlinks Those are 404 errors spotted in production. facets facets allow you to explore products according to various criterion. Based on MongoDB ⏲️ 5 minute fix 🎯 P1 candidate Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Jul 19, 2021
@pradumna-gautam pradumna-gautam mentioned this issue Apr 22, 2022
Closed
@teolemon teolemon added the Fixed ? This issue might have been fixed. We can close them once we verify that they have. label Oct 23, 2022
@teolemon
Copy link
Member Author

Still in production with the redesign (Nov 2022)

Image

@teolemon
Copy link
Member Author

teolemon commented Nov 9, 2023

Given that we have fixed perf issue on the contributors page, this issue is now impactful again.

@teolemon
Copy link
Member Author

I have spotted a similar issue on packager codes: I have a similar issue on the packager codes: https://world.openfoodfacts.org/packager-codes/emb_codes/2

@hangy hangy mentioned this issue Nov 13, 2023
Closed
@alexgarel alexgarel mentioned this issue Nov 30, 2023
Merged
alexgarel added a commit that referenced this issue Dec 4, 2023
@alexgarel
fix: fixing pagination on facets (#9443)
92c5d29 
* fixing link in pagination for contributor and translated facets
* fixing pagination for contributors query

fixes:
- #9311 
- #3850
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brokenlinks Those are 404 errors spotted in production. 🐛 bug This is a bug, not a feature request. facets facets allow you to explore products according to various criterion. Based on MongoDB non tech 🎯 P1 pagination Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. ⏲️ 5 minute fix
Projects
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
4 participants
@Ban3 @teolemon @VaiTon @jolesh