Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixing pagination on facets #9443

Merged
merged 2 commits into from
Dec 4, 2023
Merged

fix: fixing pagination on facets #9443

merged 2 commits into from
Dec 4, 2023

Conversation

alexgarel
Copy link
Member

  • fixing link in pagination for contributor and translated facets
  • fixing pagination for contributors query

fixes:

@alexgarel
fix: fixing pagination on facets
31ef5d7 
* fixing link in pagination for contributor and translated facets
* fixing pagination for contributors query
@alexgarel alexgarel requested a review from a team as a code owner November 30, 2023 17:56
@alexgarel alexgarel changed the title fix: fixing pagination on facets fix: fixing pagination on facets Nov 30, 2023
stephanegigandet
stephanegigandet approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexgarel alexgarel enabled auto-merge (squash) December 4, 2023 18:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit 92c5d29 into main Dec 4, 2023
13 checks passed
@alexgarel alexgarel deleted the fix-facets-pagination branch December 4, 2023 19:13
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 4, 2023
Merged
@stephanegigandet stephanegigandet mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@alexgarel alexgarel

Labels
Display pagination
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgarel @stephanegigandet @teolemon