Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an explanation for Eco-Score exemptions #6092

Closed
2 tasks
Tracked by #6680
teolemon opened this issue Nov 21, 2021 · 6 comments · Fixed by #6844
Closed
2 tasks
Tracked by #6680

Return an explanation for Eco-Score exemptions #6092

teolemon opened this issue Nov 21, 2021 · 6 comments · Fixed by #6844
Assignees
Labels
🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products ✨ Feature Features or enhancements to Open Food Facts server 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@teolemon
Copy link
Member

teolemon commented Nov 21, 2021

What

The eco-score does not grade bottled waters, and there's no way to know why.

Describe the solution you'd like

  • Return an explanation for Eco-Score exemptions, and a suggestion to drink tap water or self-carbonated water.
  • Expose this explanation in knowledge panels and in the legacy HTML methodology

Part of

@teolemon teolemon added ✨ Feature Features or enhancements to Open Food Facts server 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels labels Nov 21, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Feb 20, 2022
@teolemon
Copy link
Member Author

"L'Eco-Score n'est pas encore dispo pour cette catégorie."

@alexgarel
Copy link
Member

@teolemon it's not in current sprint ?

@alexgarel
Copy link
Member

alexgarel commented May 30, 2022

@teolemon @stephanegigandet we got two options here:

  • continue to consider this as "nutriscore unknown" but adapt messages
  • consider it as a new status: "nutriscore not applicable"
  • a mix of those (continue to put it as unknown but use a specific panel instead of ecoscore_unknown.tt.json)

Would you also like a different icon ?

@stephanegigandet
Copy link
Contributor

@alexgarel It should be "Eco-Score not applicable", as we do for "Nutri-Score not applicable".

In fact we already compute it:

https://uk.openfoodfacts.org/eco-score/not-applicable

ecoscore_data: {
adjustments: { },
ecoscore_not_applicable_for_category: "en:sodas",
status: "unknown"
},
ecoscore_grade: "not-applicable",
ecoscore_tags: [
"not-applicable"
],

And we will need a different icon, similar to the Nutri-Score not applicable icon.

@stephanegigandet
Copy link
Contributor

Discussed with @teolemon and @alexgarel:

  • New messages : "Eco-Score not applicable", "Nutri-Score not applicable".
  • Color should be grey.
  • Icon to be discussed. (maybe just an outline).

@stephanegigandet stephanegigandet self-assigned this May 30, 2022
stephanegigandet added a commit that referenced this issue Jun 3, 2022
…knowledge panels when not applicable (#6844)

* not-applicable ecoscore and nutriscore attributes and panels #6092 #6774

* not-applicable ecoscore and nutriscore attributes and panels #6092 #6774

* not-applicable ecoscore and nutriscore attributes and panels #6092 #6774

* Update lib/ProductOpener/Lang.pm

Co-authored-by: Alex Garel <[email protected]>

* add test for category exempted from ecoscore

Co-authored-by: Alex Garel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products ✨ Feature Features or enhancements to Open Food Facts server 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
3 participants