feat: add explanation with category in the Nutri-Score and Eco-Score knowledge panels when not applicable #6844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanegigandet
added
the
📖 Knowledge Panels -
github-actions
bot
added
Attributes
1 task
alexgarel
requested changes
Jun 2, 2022
|
Also, @stephanegigandet, could be good to add a test for eco-score not applicable… |
|
proposal for logo: |
|
@alexgarel for the logos, I made a separate PR: Santé publique France has an official logo for "Nutri-Score unknown", so I think we should use it. I think we can use the same logo for "Nutri-Score not-applicable" as well. Same for Eco-Score unknown and not-applicable (yet), we can use the same logo. |
Co-authored-by: Alex Garel <[email protected]>
…rver into nutri-eco
Good point, I added a test. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a product does not have a Nutri-Score or an Eco-Score because the product category is excluded from the Nutri-Score and Eco-Score, we now explain why in the corresponding knowledge panel, and we list the category.
Fixes #6092 and #6774