Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omega 6 and 9 placement in table #8395

Open
aleene opened this issue May 4, 2023 · 8 comments
Open

Omega 6 and 9 placement in table #8395

aleene opened this issue May 4, 2023 · 8 comments
Assignees
Labels
good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Nutrients ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. ⭐ 🐛 top bug Top bug.

Comments

@aleene
Copy link
Contributor

aleene commented May 4, 2023

Describe the bug

The fats Omega 6 and 9 appear now as a separate row, the could be place under other fats.

To Reproduce

See this product: https://world.openfoodfacts.org/product/3329489000309/huile-d-olive-bio-vierge-extra-100-espagne-1l-grand-olio

Expected behavior

Put Omega 6 under polyunsaturated fats
Put Omega 9 under monounsaturated dats

Screenshots

No response

Additional context

No response

Type of device

Browser

Browser version

No response

Number of products impacted

No response

Time per product

No response

@aleene aleene added the 🐛 bug This is a bug, not a feature request. label May 4, 2023
@alexgarel alexgarel added the good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. label May 17, 2023
@github-actions github-actions bot added the ⭐ 🐛 top bug Top bug. label May 18, 2023
@alexgarel
Copy link
Member

It might be linked to %nutriments_tables in Food.pm

It seems to use dashes ("-", "--") to set a kind of hierarchy, but I don't know if 3 level hierarchy is possible, "---" as omega-3 and omega-6 seems to have sub items.)

@Tanujgarg37
Copy link
Contributor

It might be linked to %nutriments_tables in Food.pm

It seems to use dashes ("-", "--") to set a kind of hierarchy, but I don't know if 3 level hierarchy is possible, "---" as omega-3 and omega-6 seems to have sub items.)

Can you plz elaborate

@alexgarel
Copy link
Member

Hi @Tanujgarg37 sorry for late reply.

But I think you may have to deep dive into the javascript that builds the table.
I think the %nutriments_tables in Food.pm is the one that drives the way nutriments are presented. I added a comment not so long ago, it might help you.
See https://github.com/openfoodfacts/openfoodfacts-server/blob/main/lib/ProductOpener/Food.pm#L336

@Tanujgarg37
Copy link
Contributor

Tanujgarg37 commented Jul 27, 2023 via email

@owais0017
Copy link

Assign this to me. i am already working on another issue related the to the same table, i have a good understanding of the table. can you please assign the issue to me?

@Tanujgarg37
Copy link
Contributor

Tanujgarg37 commented Aug 13, 2023 via email

Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the Stale label Nov 12, 2023
@teolemon teolemon added ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. and removed Stale labels Nov 24, 2023
@aleene aleene self-assigned this Dec 21, 2023
@aleene
Copy link
Contributor Author

aleene commented Dec 21, 2023

see #9569

@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Nutrients ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. ⭐ 🐛 top bug Top bug.
Projects
Status: To discuss and validate
Development

No branches or pull requests

5 participants