fix: Repair fat placements #9569
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9569 +/- ##
=======================================
Coverage ? 49.04%
=======================================
Files ? 66
Lines ? 20532
Branches ? 4944
=======================================
Hits ? 10070
Misses ? 9170
Partials ? 1292 ☔ View full report in Codecov by Sentry. |
|
@aleene We currently support only 3 levels. We could add more levels, it just needs some changes in the code and the templates. But it won't solve all issues. Look at this product for instance: https://world.openfoodfacts.org/product/3366321051983/omega-3-doux-st-hubert
The table in Food.pm is currently used to set up the order of the nutrients, and their level. But we currently do not use it to show nutrients for which we don't have values, but for which we have values for sub-nutrients. So for this product, we miss "insaturated fat", so we will show something that looks like:
Which will look like if mono/poly insaturated fat is part of saturated fat... So we will need more changes in the code, to display en empty line for insaturated fat even though we don't have values for it. |
|
OK, we can make a separate issue for that. |
|
|
I tested, I got this: |
| '-omega-6-fat-', '--linoleic-acid-', | ||
| '-unsaturated-fat-', '--monounsaturated-fat-', | ||
| '---omega-9-fat-', '--polyunsaturated-fat-', | ||
| '---omega-3-fat-', '---omega-6-fat-', |
There was a problem hiding this comment.
the fact to have four dashes does not harm however, it's displayed as 3 :-)
What
Repaired the placement on mon- and polyunsaturated fats in the nutritional table
Related issue(s) and discussion