Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the fly quality checks issues #8420

Open
CharlesNepote opened this issue May 15, 2023 · 3 comments
Open

On the fly quality checks issues #8420

CharlesNepote opened this issue May 15, 2023 · 3 comments
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧽 on-the-fly quality checks ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@CharlesNepote
Copy link
Member

CharlesNepote commented May 15, 2023

What

  • There are at issues with online quality checks.
  1. The quality check is wrongly triggered in the Kcal and KJ fields

image

  • KJ should always be < 3800 (per 100 g).
  • Kcal should always be < 900 (per 100 g).
  1. The quality check is triggered for value > 100 even if unit is mg

If the unit is mg, then it should be < 100,000. Same issue for µg, etc.

image

  1. Helper in black is under the image (see previous screenshot).

  2. The quality check should be triggered at page load, even if the user does not enter anything.

To Reproduce

See any page in edition. Eg. https://world.openfoodfacts.org/cgi/product.pl?type=edit&code=8410764010474

Context

Part of

@CharlesNepote CharlesNepote added 🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality labels May 15, 2023
@benbenben2
Copy link
Collaborator

Related to this, if it could be possible to use the "<" symbol without having the field in red, that would be great as well:
image

@github-actions
Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. and removed ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. labels Aug 28, 2023
Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Dec 17, 2023
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧽 on-the-fly quality checks ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To discuss and validate
Status: To do
Development

No branches or pull requests

3 participants