Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: on the fly nutrition edit checks #8420 #8464

Merged
merged 2 commits into from
May 29, 2023
Merged

fix: on the fly nutrition edit checks #8420 #8464

merged 2 commits into from
May 29, 2023

Conversation

stephanegigandet
Copy link
Contributor

Solves most of the issues reported by @CharlesNepote and @benbenben2 in #8420

image

Does not address the tooltip below the image issue.

@stephanegigandet stephanegigandet requested a review from a team as a code owner May 26, 2023 15:34
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels May 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

CharlesNepote
CharlesNepote approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@CharlesNepote CharlesNepote left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good but didn't check on dev. Could you merge to let us verify on openfoodfacts.net?

@stephanegigandet stephanegigandet merged commit a82b5ea into main May 29, 2023
@stephanegigandet stephanegigandet deleted the product-edit-checks branch May 29, 2023 07:51
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request May 29, 2023
Merged
MonalikaPatnaik pushed a commit to MonalikaPatnaik/openfoodfacts-server that referenced this pull request May 31, 2023
@stephanegigandet @MonalikaPatnaik
fix: on the fly nutrition edit checks openfoodfacts#8420 (openfoodfac…
f9d63fe 
…ts#8464)

* fix: on the fly nutrition edit checks openfoodfacts#8420

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesNepote CharlesNepote CharlesNepote approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @CharlesNepote