Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: jp_allergens_1 (Combined) #9594

Merged
merged 10 commits into from
Dec 25, 2023
Merged

taxonomy: jp_allergens_1 (Combined) #9594

merged 10 commits into from
Dec 25, 2023

Conversation

Naruyoko
Copy link
Contributor

What

Rebase of #9502 + #9505.

Added some allergens in JP. Added as synonym when available

Extends #9502, referring to the same document.

@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥜 Allergens categories 🧪 tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🧪 integration tests 🥗 Ingredients labels Dec 24, 2023
@Naruyoko Naruyoko marked this pull request as ready for review December 24, 2023 23:38
@Naruyoko Naruyoko requested a review from a team as a code owner December 24, 2023 23:38
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2654a07) 49.28% compared to head (71a2961) 49.28%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9594   +/-   ##
=======================================
  Coverage   49.28%   49.28%           
=======================================
  Files          66       66           
  Lines       20546    20546           
  Branches     4946     4946           
=======================================
  Hits        10126    10126           
  Misses       9132     9132           
  Partials     1288     1288

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii label Dec 25, 2023
@github-actions github-actions bot removed the ✏️ Editing - Auto Suggest Providing autosuggest for taxonomized fields. Mostly used in editing scenarii label Dec 25, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

benbenben2
benbenben2 approved these changes Dec 25, 2023
View reviewed changes
Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thank you @Naruyoko

@benbenben2
Copy link
Collaborator

Closes #9502
Closes #9505

@benbenben2 benbenben2 merged commit f915975 into openfoodfacts:main Dec 25, 2023
12 checks passed
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 25, 2023
Merged
@Naruyoko Naruyoko mentioned this pull request Dec 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbenben2 benbenben2 benbenben2 approved these changes

Assignees

@Naruyoko Naruyoko

Labels
🥜 Allergens API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) categories 🥗 Ingredients 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Naruyoko @codecov-commenter @benbenben2