-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: Add even more synonyms to jp_allergens_1
#9505
Conversation
taxonomies/categories.txt
Outdated
@@ -91019,6 +91020,7 @@ es:Caballa | |||
fi:makrillit | |||
fr:Maquereaux | |||
it:Sgombro | |||
ja:サケ, 鮭, しゃけ, シャケ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERROR - ja:サケ already is associated to en:salmons (categories) - ja:サケ cannot be mapped to entry en:mackerels
ja:サケ, 鮭, しゃけ, シャケ | |
ja:鮭, しゃけ, シャケ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
サケ appears 2 times in the same file, for different categories. This is the reason why the test fails.
After looking at wikipedia page and translation, I suggest to remove it from mackerels and keep it for salmons.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I should have moved サバ etc. there instead, but probably copied the wrong parts of the line. Actually, the correct translations for mackerels were already there, but for some reason assigned to en:Mackerel fillets
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a fix.
It looks like there are still conflicts in the taxonomy. Some of them seem to be unrelated to my changes, but others are relevant here, for example ビーフ. I fixed some of the easy ones (and hopefully all the ones that I broke here), preferring to designate to the parent entries. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jp_allergens_1 #9505 +/- ##
===============================================
Coverage 49.03% 49.03%
===============================================
Files 66 66
Lines 20434 20434
Branches 4905 4905
===============================================
Hits 10019 10019
Misses 9147 9147
Partials 1268 1268 ☔ View full report in Codecov by Sentry. |
Try to click on "update branch" in your PR. That should merge with new PR that have been merged. And hopefully remove the failed test and the POD error. |
I don't see the button, which I think is because I'm trying to merge into |
I just clicked on the button for the pr |
259dbe4
to
8ccfddd
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@Naruyoko, maybe that could be easier to make your pr to main directly instead of my branch. |
Okay. I made a new PR. |
* jp_allergens_1 * rework and upd tests * recreate tests * Add more `jp` synonyms * Reflect some `ja` allergen synonyms to other taxonomies * jp to ja * More jp to ja * Fix ja for salmons and mackerels See #9505 (comment) * Fix some ja duplicates, preferring the parents * Recreate tests --------- Co-authored-by: benbenben2 <[email protected]>
Replaced by #9594. |
What
Extends #9502, referring to the same document.