-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: jp_allergens_1 #9502
taxonomy: jp_allergens_1 #9502
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9502 +/- ##
=======================================
Coverage 49.24% 49.25%
=======================================
Files 66 66
Lines 20532 20532
Branches 4944 4944
=======================================
+ Hits 10112 10113 +1
Misses 9132 9132
+ Partials 1288 1287 -1 ☔ View full report in Codecov by Sentry. |
Reworked the order to make appear the one from the document in first position (those will appear on the website for allergens) Different allergens from the Japanese document are found inside the same block in the taxonomy. Example: walnuts (くるみ) and almonds (アーモンド). Instead of splitting the block into two blocks (todo in the future?), I just added them as synonyms, and the first element of the line contains both with a slash: くるみ/アーモンド. Tests containing "apple" failed after the changes (apple is an allergen in Japan). So, tests were updated. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Replaced by #9502 |
What
Added some allergens in JP. Added as synonym when available
according to this document: https://www.caa.go.jp/policies/policy/food_labeling/food_sanitation/allergy/assets/food_labeling_cms204_210514_01.pdf
see chapter 3 (page 28)
see also table of comparison with other countries regulations (page 7)
See also this document in English: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC8691970/
See Table 1
Related issue(s) and discussion