Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: jp_allergens_1 #9502

Closed
wants to merge 7 commits into from
Closed

taxonomy: jp_allergens_1 #9502

wants to merge 7 commits into from

Conversation

benbenben2
Copy link
Collaborator

What

Added some allergens in JP. Added as synonym when available

according to this document: https://www.caa.go.jp/policies/policy/food_labeling/food_sanitation/allergy/assets/food_labeling_cms204_210514_01.pdf
see chapter 3 (page 28)
see also table of comparison with other countries regulations (page 7)

See also this document in English: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC8691970/
See Table 1

Related issue(s) and discussion

  • Fixes #-none-

@benbenben2 benbenben2 added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥜 Allergens 🇯🇵 Japan https://jp.openfoodfacts.org/ labels Dec 8, 2023
@benbenben2 benbenben2 self-assigned this Dec 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0a576a) 49.24% compared to head (ba98676) 49.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9502   +/-   ##
=======================================
  Coverage   49.24%   49.25%           
=======================================
  Files          66       66           
  Lines       20532    20532           
  Branches     4944     4944           
=======================================
+ Hits        10112    10113    +1     
  Misses       9132     9132           
+ Partials     1288     1287    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benbenben2 benbenben2 requested a review from a team as a code owner December 10, 2023 15:58
@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧪 tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🧪 integration tests labels Dec 10, 2023
@benbenben2
Copy link
Collaborator Author

Reworked the order to make appear the one from the document in first position (those will appear on the website for allergens)

Different allergens from the Japanese document are found inside the same block in the taxonomy. Example: walnuts (くるみ) and almonds (アーモンド). Instead of splitting the block into two blocks (todo in the future?), I just added them as synonyms, and the first element of the line contains both with a slash: くるみ/アーモンド.

Tests containing "apple" failed after the changes (apple is an allergen in Japan). So, tests were updated.

@benbenben2 benbenben2 mentioned this pull request Dec 12, 2023
Copy link

sonarcloud bot commented Dec 17, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@benbenben2
Copy link
Collaborator Author

Replaced by #9502

@benbenben2 benbenben2 closed this Dec 25, 2023
@benbenben2 benbenben2 deleted the jp_allergens_1 branch May 18, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥜 Allergens API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧪 integration tests 🇯🇵 Japan https://jp.openfoodfacts.org/ 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants