-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: viili #8906
taxonomy: viili #8906
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8906 +/- ##
==========================================
+ Coverage 45.54% 46.05% +0.51%
==========================================
Files 64 64
Lines 19519 19795 +276
Branches 4738 4792 +54
==========================================
+ Hits 8889 9116 +227
- Misses 9454 9494 +40
- Partials 1176 1185 +9 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
See some suggestions.
<en:Fruit juice concentrates | ||
en:Lemon juice concentrates, concentrated lemon juices | ||
fr:Concentrés de jus de citrons, Jus de citrons concentrés | ||
|
||
<en:Fruit juice concentrates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this block because "concentrates, concentrated, juice, juices" in EN as well as "concentrés de", "jus de", "concentrés" in FR are in ingredients_processing.txt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is the category taxonomy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct! my mistake
taxonomies/categories.txt
Outdated
@@ -46033,6 +46040,14 @@ en:Fruit skyrs, Fruit skyr | |||
fr:Skyrs aux fruits, Skyr aux fruits | |||
nl:Skyrs met vruchten | |||
|
|||
<en:Fermented dairy desserts | |||
fi:Viili |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fi:Viili | |
en:Viili | |
da:Viili | |
de:Viili | |
es:Viili | |
fi:Viili |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's almost never translated, then we can just add xx:Viili
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't put any other translation because I didn't want to favour the finnish term over the swedish one or the opposite. But I can put both in xx:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do need the en: entry first, even if it's the same as the xx: entry, this is just so that all ingredients entries have a en: canonical name (not exactly the case today, but we should try do to that)
taxonomies/categories.txt
Outdated
@@ -46033,6 +46040,14 @@ en:Fruit skyrs, Fruit skyr | |||
fr:Skyrs aux fruits, Skyr aux fruits | |||
nl:Skyrs met vruchten | |||
|
|||
<en:Fermented dairy desserts | |||
fi:Viili | |||
sv:Filmjölk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sv:Filmjölk | |
fr:Viili | |
ko:빌리 | |
nl:Viili | |
pl:Viili | |
sv:Filbunke, Filmjölk | |
wikidata:en:Q14732517 | |
description:en:Fermented Finnish Milk Product |
For new ingredients, you can search on wikidata and if it exists, you can add all translations
Also, for new ingredients, you can try to find the EN translation and put it on top
Kudos, SonarCloud Quality Gate passed! |
What
Screenshot
Related issue(s) and discussion