Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: viili #8906

Merged
merged 4 commits into from
Sep 5, 2023
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions taxonomies/categories.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5858,11 +5858,6 @@ en:Lime juices from concentrate
fr:Jus de citron vert à partir d'un concentré
nl:limoensappen uit concentraat

<en:Lime juices
<en:Fruit juice concentrates
en:Lime juice concentrates, concentrated lime juices
fr:Concentrés de jus de citrons verts, Jus de citrons verts concentrés

<en:Fruit juices
en:Lemon juice
bg:Лимонов сок
Expand Down Expand Up @@ -8370,11 +8365,14 @@ fr:Concentrés de jus de fruits, jus de fruits concentrés
en:Apple juice concentrates, concentrated apple juices
fr:Concentrés de jus de pommes, Jus de pommes concentrés

<en:Squeezed lemon juices
<en:Fruit juice concentrates
en:Lemon juice concentrates, concentrated lemon juices
fr:Concentrés de jus de citrons, Jus de citrons concentrés

<en:Fruit juice concentrates
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this block because "concentrates, concentrated, juice, juices" in EN as well as "concentrés de", "jus de", "concentrés" in FR are in ingredients_processing.txt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is the category taxonomy

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct! my mistake

en:Lime juice concentrates, concentrated lime juices
fr:Concentrés de jus de citrons verts, Jus de citrons verts concentrés

<en:Plant-based foods and beverages
en:Dairy substitutes, Dairies substitutes
bg:Заместители на млечни продукти
Expand Down Expand Up @@ -34630,6 +34628,14 @@ fr:Riz au lait saveur vanille
lt:Vaniliniai ryžių pudingai
nl:Rijstpudding met vanille

<en:Rice puddings
en:Plain rice puddings
fr:Riz au lait nature

<en:Rice puddings
en:Rice puddings with a fruit preparation
fr:Riz au lait à la préparation de fruits

<en:Cakes
en:Fruit cakes, Fruit cake
de:Obstkuchen, Fruchtkuchen
Expand Down Expand Up @@ -34849,8 +34855,9 @@ food_groups:en: en:Sweets
pnns_group_2:en:Sweets

<en:Confectioneries
fr:Substituts du chocolat
en:Chocolate substitutes
en:Compound chocolates, Chocolate substitutes
de:Schokoladenersatz
fr:Succédanés du chocolat, Substituts du chocolat
ja:凖チョコレート
# ja note: Industry policy:
# チョコレート類 refers to chocolate products in Japan. It contains チョコレート ("chocolate"), 凖チョコレート, チョコレート菓子 ("chocolate snack"), 凖チョコレート菓子, カカオマス ("cocoa mass"), ココアバター ("cocoa butter"), ココアケーキ, ココアパウダー ("cocoa powder"), and 調整ココアパウダー.
Expand Down Expand Up @@ -46033,6 +46040,14 @@ en:Fruit skyrs, Fruit skyr
fr:Skyrs aux fruits, Skyr aux fruits
nl:Skyrs met vruchten

<en:Fermented dairy desserts
fi:Viili
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fi:Viili
en:Viili
da:Viili
de:Viili
es:Viili
fi:Viili

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's almost never translated, then we can just add xx:Viili

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't put any other translation because I didn't want to favour the finnish term over the swedish one or the opposite. But I can put both in xx:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do need the en: entry first, even if it's the same as the xx: entry, this is just so that all ingredients entries have a en: canonical name (not exactly the case today, but we should try do to that)

sv:Filmjölk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sv:Filmjölk
fr:Viili
ko:빌리
nl:Viili
pl:Viili
sv:Filbunke, Filmjölk
wikidata:en:Q14732517
description:en:Fermented Finnish Milk Product

For new ingredients, you can search on wikidata and if it exists, you can add all translations
Also, for new ingredients, you can try to find the EN translation and put it on top


<fi:Viili
<en:Fermented dairy desserts with fruits
sv:Filmjölk med frukt

<en:Fermented milk products
# <en:ingredient:en:cheese
en:Quarks, quark
Expand Down Expand Up @@ -46100,14 +46115,6 @@ en:Fruit quarks, Fruit quark
fr:Quarks aux fruits, Quark aux fruits
nl:Kwarks met vruchten

<en:Quarks
en:Curd snacks
lt:Varškės sūreliai

<en:Quarks
en:Curd snacks
lt:Varškės sūreliai

<en:Quarks
en:Herb quarks
de:Kräuterquark
Expand Down
Loading