Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use title_element #1620

Merged
merged 3 commits into from
Apr 23, 2022
Merged

fix: use title_element #1620

merged 3 commits into from
Apr 23, 2022

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Apr 22, 2022

What

"title_element":{"title":"Santé"},"topics":["health"],"type":"card"}
"title_element":{"title":""},"topics":["environment"],"type":"card"}
@teolemon teolemon requested a review from a team as a code owner April 22, 2022 18:36
@teolemon teolemon self-assigned this Apr 22, 2022
@teolemon
Copy link
Member Author

error • The getter 'title_element' isn't defined for the type 'KnowledgePanel' • packages/smooth_app/lib/cards/product_cards/knowledge_panels/knowledge_panel_card.dart:34:37 • undefined_getter

@teolemon teolemon added this to the V1 milestone Apr 22, 2022
@M123-dev
Copy link
Member

M123-dev commented Apr 23, 2022

@teolemon we named it titleElement not title_element in off-dart, updated the PR now just the url launcher deprecation if failing

https://github.com/openfoodfacts/openfoodfacts-dart/blob/527b2e7ea484839ccfc9bb6ffc812b3d966e0924/lib/model/KnowledgePanel.dart#L82

@codecov-commenter
Copy link

Codecov Report

Merging #1620 (19c528f) into develop (2ea0da3) will decrease coverage by 0.14%.
The diff coverage is 1.79%.

@@            Coverage Diff             @@
##           develop   #1620      +/-   ##
==========================================
- Coverage     8.86%   8.71%   -0.15%     
==========================================
  Files          161     164       +3     
  Lines         6623    6789     +166     
==========================================
+ Hits           587     592       +5     
- Misses        6036    6197     +161     
Impacted Files Coverage Δ
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...rds/knowledge_panels/knowledge_panels_builder.dart 2.17% <0.00%> (ø)
...s/product_cards/smooth_product_card_not_found.dart 0.00% <0.00%> (ø)
.../smooth_app/lib/data_models/onboarding_loader.dart 0.00% <ø> (ø)
...mooth_app/lib/data_models/product_query_model.dart 1.38% <ø> (ø)
...s/smooth_app/lib/data_models/user_preferences.dart 34.42% <ø> (+2.11%) ⬆️
...s/smooth_app/lib/database/dao_string_list_map.dart 0.00% <0.00%> (ø)
...ckages/smooth_app/lib/database/local_database.dart 0.00% <0.00%> (ø)
...s/smooth_app/lib/database/paged_product_query.dart 0.00% <0.00%> (ø)
...oth_app/lib/database/robotoff_questions_query.dart 0.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51691d...19c528f. Read the comment docs.

@M123-dev M123-dev merged commit bbecb75 into develop Apr 23, 2022
@M123-dev M123-dev deleted the title_element branch April 23, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants