Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated Environnement title in the Knowledge panels (logic error ?) #1540

Closed
1 task
Tracked by #1462
teolemon opened this issue Apr 11, 2022 · 3 comments · Fixed by #1665
Closed
1 task
Tracked by #1462

Duplicated Environnement title in the Knowledge panels (logic error ?) #1540

teolemon opened this issue Apr 11, 2022 · 3 comments · Fixed by #1665
Assignees
@cli1005
Labels
📖 Knowledge panels 🎯 P0
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Apr 11, 2022 •
edited
Loading

What

  • Duplicated Environnement title
  • Currently unsure if client side or server side, or if it's only provoked by the custom eco-score card

Screenshots

image
@teolemon teolemon mentioned this issue Apr 11, 2022
Open
@stephanegigandet
Copy link
Contributor

There's no "Environment" string in the knowledge panels: https://world.openfoodfacts.org/product/3017620422003/nutella-ferrero?fields=knowledge_panels

On the website this is what we show:

image

Probably related to #1534

The app may be trying to use the "topic" field instead of using the translated titles.

@stephanegigandet stephanegigandet removed their assignment Apr 11, 2022
@teolemon
Copy link
Member Author

@stephanegigandet it seems there are uncoherent behaviours, see my comment in #1534

@teolemon teolemon added this to the V1 milestone Apr 15, 2022
@teolemon teolemon mentioned this issue Apr 22, 2022
Merged
@teolemon teolemon changed the title Duplicated Environnement title Duplicated Environnement title in the Knowledge panels (logic error ?) Apr 22, 2022
@cli1005 cli1005 self-assigned this Apr 26, 2022
@cli1005
Copy link
Contributor

cli1005 commented Apr 26, 2022

BEFORE
According to the actuel code, the panel.topics will show when the next panel has title_element.type = grade

AFTER
title_element.title will show once when building each panel inside the root panel

BEFORE AFTER
Simulator Screen Shot - iPhone 13 - 2022-04-26 at 12 48 18 Simulator Screen Shot - iPhone 13 - 2022-04-26 at 12 48 28 Simulator Screen Shot - iPhone 13 - 2022-04-26 at 12 49 29 Simulator Screen Shot - iPhone 13 - 2022-04-26 at 12 49 34

cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 27, 2022
@cli1005
fix: openfoodfacts#1540 - duplicated panel title
fc236d8
cli1005 added a commit to cli1005/smooth-app that referenced this issue Apr 27, 2022
@cli1005
fix: openfoodfacts#1540 - refactoring
82d31ec
@cli1005 cli1005 mentioned this issue Apr 27, 2022
Merged
@teolemon teolemon linked a pull request Apr 27, 2022 that will close this issue
fix: #1540 - duplicated panel title #1665
Merged
cli1005 added a commit that referenced this issue Apr 29, 2022
@cli1005
fix: #1540 - duplicated panel title (#1665)
af7ce55 
* fix: #1540 - duplicated panel title

* fix: #1540 - refactoring
@github-actions github-actions bot mentioned this issue Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cli1005 cli1005

Labels
📖 Knowledge panels 🎯 P0
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

fix: #1540 - duplicated panel title cli1005/smooth-app
4 participants
@teolemon @stephanegigandet @olivierdrouard @cli1005