fix: #1540 - duplicated panel title

[cli1005]

What

Duplicated Environment title, more détails : #1540 (comment)

Screenshot

Fixes bug(s)

• Duplicated Environnement title in the Knowledge panels (logic error ?) #1540
• The localized title of cards is not picked up #1534

[codecov-commenter]

Codecov Report

Merging #1665 (82d31ec) into develop (2ea0da3) will decrease coverage by 0.53%.
The diff coverage is 0.50%.

@@            Coverage Diff             @@
##           develop   #1665      +/-   ##
==========================================
- Coverage     8.86%   8.32%   -0.54%     
==========================================
  Files          161     165       +4     
  Lines         6623    7111     +488     
==========================================
+ Hits           587     592       +5     
- Misses        6036    6519     +483     

Impacted Files	Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart	0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart	0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart	0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart	0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart	0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart	0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart	0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart	0.00% <ø> (ø)
...rds/knowledge_panels/knowledge_panels_builder.dart	2.00% <0.00%> (-0.18%)	⬇️
...cards/product_cards/smooth_product_card_found.dart	0.00% <0.00%> (ø)
... and 42 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a2feb...82d31ec. Read the comment docs.

[monsieurtanuki]

@cli1005 I did not open the issue, but I think the problem was that the "Environment" label was there twice, and it was expected only once.
In your screenshots, you do fix that for the product page (screenshot 1), but on the detail page "Environment" is not written at all anymore (screenshot 2). I would expect the same behavior as on the product page: one "Environment" on top (or as page title).
What do you think of that?

[cli1005]

@cli1005 I did not open the issue, but I think the problem was that the "Environment" label was there twice, and it was expected only once. In your screenshots, you do fix that for the product page (screenshot 1), but on the detail page "Environment" is not written at all anymore (screenshot 2). I would expect the same behavior as on the product page: one "Environment" on top (or as page title). What do you think of that?

The label(title) was displayed with all panel of type "grade", you could check the comment to see the snapshots BEFORE and AFTER #1540 (comment).
The title was duplicated as well in page opened by tapping the panel which contains several "grade" panels, which is not logic for me... since if we tap a panel which doesn't have "grade" panel , we will open a page without title as following snapshot:

[teolemon]

@cli1005 it's great to see that some Chinese seems to be working :-)

[monsieurtanuki]

Hi @cli1005!

Not convinced by the choices of

• not showing an obvious page title
• using context == null to decide to display a title or not

But anyway things look better with this PR!