feat: 3207 - edit page for website product field #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `add_other_details_page.dart`: Input of a product's less significant details, like website. Impacted files: * `app_en.arb`: added 2 labels in order to describe the click to new page `AddOtherDetailsPage` * `app_fr.arb`: added 2 labels in order to describe the click to new page `AddOtherDetailsPage` * `edit_product_page.dart`: added a call to new page `AddOtherDetailsPage` for website input * `new_product_page.dart`: minor bug fix * `up_to_date_changes.dart`: added the `website` field to the copy; unrelated code simplification * `up_to_date_product_provider.dart`: unrelated code simplification
github-actions
bot
added
🌐 l10n
Product addition
M123-dev
approved these changes
Nov 29, 2022
|
Thank you @M123-dev for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New file:
add_other_details_page.dart: Input of a product's less significant details, like website.Impacted files:
app_en.arb: added 2 labels in order to describe the click to new pageAddOtherDetailsPageapp_fr.arb: added 2 labels in order to describe the click to new pageAddOtherDetailsPageedit_product_page.dart: added a call to new pageAddOtherDetailsPagefor website inputnew_product_page.dart: minor bug fixup_to_date_changes.dart: added thewebsitefield to the copy; unrelated code simplificationup_to_date_product_provider.dart: unrelated code simplificationWhat
Screenshot
Fixes bug(s)