Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localisation: nl_NL #21

Closed
SomeGeek opened this issue Jun 14, 2019 · 10 comments
Closed

Localisation: nl_NL #21

SomeGeek opened this issue Jun 14, 2019 · 10 comments
Assignees
@SomeGeek
Labels
enhancement New feature or request
Milestone
First Stable Release

Comments

@SomeGeek
Copy link
Contributor

Will provide a Dutch i18n file later this weekend!
@thomas-kl1 thomas-kl1 added the enhancement New feature or request label Jun 14, 2019
@thomas-kl1
Copy link
Member

thomas-kl1 commented Jun 14, 2019 •
edited
Loading

Thanks :) any help is welcomed! Please use the latest head of master and the i18n command line generator, the current csv are out of date.

@SomeGeek
Copy link
Contributor Author

SomeGeek commented Jun 16, 2019 •
edited
Loading

Ready to merge: #22

@thomas-kl1 thomas-kl1 added fixed Issue has been fixed in progress Work is in progress and removed fixed Issue has been fixed labels Jun 16, 2019
@thomas-kl1 thomas-kl1 reopened this Jun 16, 2019
@SomeGeek
Copy link
Contributor Author

Just out of my curiosity: Why did you reopen this issue?

@thomas-kl1
Copy link
Member

The translation file you provide does not contains all translations. The current files: fr_FR.csv and en_US.csv are not up-to-date.

Please use the following command to generate the correct translation file:
bin/magento i18n:collect-phrases

See 4bc88e0 for the latest changes

@SomeGeek
Copy link
Contributor Author

Will look into it. What is the best way to merge my current translations with the new ones?

@thomas-kl1 thomas-kl1 added this to the First Stable Release milestone Jun 17, 2019
@SomeGeek SomeGeek mentioned this issue Jun 18, 2019
Merged
@SomeGeek
Copy link
Contributor Author

I updated the Dutch translations. I found some things tricky to translate, as some words don't have a direct Dutch equivalent. I did my best, though.

If someone with more 'law experience' knows better words or phrases, feel free to commit!

@thomas-kl1
Copy link
Member

Thanks a lot @SomeGeek for your contributions :)

thomas-kl1 added a commit that referenced this issue Jun 18, 2019
@thomas-kl1
update translations #21 #20
96333f4
@thomas-kl1 thomas-kl1 added holded This is in hold and removed in progress Work is in progress labels Sep 23, 2019
@thomas-kl1
Copy link
Member

Blocked by #1

@thomas-kl1
Copy link
Member

thomas-kl1 commented Dec 17, 2019 •
edited
Loading

Translations are now available here:

https://www.transifex.com/opengento/opengentomagento2-gdpr/translate/#nl_NL/en_uscsv/188723379

@thomas-kl1 thomas-kl1 added in progress Work is in progress and removed holded This is in hold labels Dec 17, 2019
@thomas-kl1
Copy link
Member

Transferred to #55

@thomas-kl1 thomas-kl1 removed the in progress Work is in progress label Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SomeGeek SomeGeek

Labels
enhancement New feature or request
Projects
None yet
Milestone
First Stable Release
Development

No branches or pull requests
2 participants
@SomeGeek @thomas-kl1