Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[neeo] Fix Servlet exceptions due to non-unique names #14554

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 8, 2023

It seems that Pax Web nowadays checks that the Servlet names are unique.

See: ServletModel.addServletModel

Fixes #14545

It seems that Pax Web nowadays checks that the Servlet names are unique.

Fixes openhab#14545

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Mar 8, 2023
@wborn wborn requested a review from a team March 8, 2023 16:35
@wborn wborn requested a review from tmrobert8 as a code owner March 8, 2023 16:35
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur merged commit 81f8738 into openhab:main Mar 8, 2023
@jlaur jlaur added this to the 4.0 milestone Mar 8, 2023
@wborn wborn deleted the neeo-unique-servlet-names branch March 8, 2023 19:23
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
It seems that Pax Web nowadays checks that the Servlet names are unique.

Fixes openhab#14545

Signed-off-by: Wouter Born <[email protected]>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
It seems that Pax Web nowadays checks that the Servlet names are unique.

Fixes openhab#14545

Signed-off-by: Wouter Born <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/ipcamera-new-ip-camera-binding/42771/2864

apella12 added a commit to apella12/openhab-addons that referenced this pull request Apr 22, 2023
[IP camera] on OH4 has the same servlet issue that was fixed by PR openhab#14554.  This PR uses that PR as a template to fix the issue in the IPcamera binding.  (That issue being that only one camera was able to stream.) This was tested locally on OH4M2 and it works.

Signed-off-by: Bob Eckhoff  <[email protected]>
apella12 added a commit to apella12/openhab-addons that referenced this pull request Apr 22, 2023
[IP camera] on OH4 has the same servlet issue that was fixed by PR openhab#14554.  This PR uses that PR as a template to fix the issue in the IPcamera binding.  (That issue being that only one camera was able to stream.) This was tested locally on OH4M2 and it works.

Signed-off-by: Bob Eckhoff  <[email protected]>
Signed-off-by: Bob Eckhoff <[email protected]>
apella12 added a commit to apella12/openhab-addons that referenced this pull request Apr 23, 2023
[IP camera] on OH4 has the same servlet issue that was fixed by PR openhab#14554.  This PR uses that PR as a template to fix the issue in the IPcamera binding.  (That issue being that only one camera was able to stream.) This was tested locally on OH4M2 and it works.

Signed-off-by: Bob Eckhoff  <[email protected]>
Signed-off-by: Bob Eckhoff <[email protected]>
jlaur pushed a commit that referenced this pull request Apr 23, 2023
* [ipcamera] Fix servlet exceptions due to non unique names

[IP camera] on OH4 has the same servlet issue that was fixed by PR #14554.  This PR uses that PR as a template to fix the issue in the IPcamera binding.  (That issue being that only one camera was able to stream.) This was tested locally on OH4M2 and it works.

Signed-off-by: Bob Eckhoff  <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
)

* [ipcamera] Fix servlet exceptions due to non unique names

[IP camera] on OH4 has the same servlet issue that was fixed by PR openhab#14554.  This PR uses that PR as a template to fix the issue in the IPcamera binding.  (That issue being that only one camera was able to stream.) This was tested locally on OH4M2 and it works.

Signed-off-by: Bob Eckhoff  <[email protected]>
Signed-off-by: Matt Myers <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/sony-devices-binding-for-oh3/124388/143

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/blink-binding/132328/47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[neeo] ops4j webservice duplicate servlet
3 participants