Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amazonechocontrol] Fix Servlet exceptions due to non-unique names #16152

Merged
merged 1 commit into from
Dec 31, 2023
Merged

[amazonechocontrol] Fix Servlet exceptions due to non-unique names #16152

merged 1 commit into from
Dec 31, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Dec 30, 2023

Fixes #16149

Similar to #14554

@wborn wborn added the bug An unexpected problem or unintended behavior of an add-on label Dec 30, 2023
@wborn wborn requested a review from mgeramb as a code owner December 30, 2023 19:55
@wborn wborn requested a review from a team December 30, 2023 19:56
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/3-4-0-4-1-0-amazon-echo-control-does-not-work-with-two-accounts-anymore/152336/7

jlaur
jlaur approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur merged commit eba975c into openhab:main Dec 31, 2023
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Dec 31, 2023
jlaur pushed a commit that referenced this pull request Dec 31, 2023
@wborn @jlaur
[amazonechocontrol] Fix Servlet exceptions due to non-unique names (#…
4269e3e 
…16152)

Fixes #16149

Signed-off-by: Wouter Born <[email protected]>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Dec 31, 2023
@wborn wborn deleted the amazonechocontrol-servlet-name branch December 31, 2023 06:58
dbadia pushed a commit to dbadia/openhab2-addons that referenced this pull request Dec 31, 2023
@wborn @dbadia
[amazonechocontrol] Fix Servlet exceptions due to non-unique names (o…
4d83bb6 
…penhab#16152)

Fixes openhab#16149

Signed-off-by: Wouter Born <[email protected]>
Cybso pushed a commit to Cybso/openhab-addons that referenced this pull request Jan 5, 2024
@wborn @Cybso
[amazonechocontrol] Fix Servlet exceptions due to non-unique names (o…
7715d3b 
…penhab#16152)

Fixes openhab#16149

Signed-off-by: Wouter Born <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@wborn @austvik
[amazonechocontrol] Fix Servlet exceptions due to non-unique names (o…
3b0aeaf 
…penhab#16152)

Fixes openhab#16149

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@wborn @joni1993
[amazonechocontrol] Fix Servlet exceptions due to non-unique names (o…
d1c77f1 
…penhab#16152)

Fixes openhab#16149

Signed-off-by: Wouter Born <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[amazonechocontrol] Multiple Amazon Accounts are not working anymore
3 participants
@wborn @openhab-bot @jlaur