[mqtt.homeassistant] Support color temp on JSON schema lights #14839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
changed the title
antroids
requested changes
Apr 24, 2023
...src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/JSONSchemaLight.java
Show resolved
Hide resolved
.../src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/LightColorMode.java
Outdated
Show resolved
Hide resolved
lolodomo
added
the
enhancement
also adds a color_mode channel if color temp is possible, so you can know how the bulb is behaving Signed-off-by: Cody Cutrer <[email protected]>
Signed-off-by: Cody Cutrer <[email protected]>
ccutrer
force-pushed
the
mqtt-homeassistant-json-light-color-temp
branch
from
39380cc
to
134681a
Compare
|
Force pushed to rebase so tests would pass with changes to HSBType's handling of conversions. New changes were added as a separate commit. |
antroids
approved these changes
Nov 14, 2023
|
LGTM, thank you! |
ccutrer
added a commit
to ccutrer/openhab-addons
that referenced
this pull request
Nov 18, 2023
Due to openhab#15427 and openhab#14839 being developed independently, but merged to main successively Signed-off-by: Cody Cutrer <[email protected]>
jlaur
pushed a commit
that referenced
this pull request
Nov 18, 2023
Due to #15427 and #14839 being developed independently, but merged to main successively Signed-off-by: Cody Cutrer <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Nov 26, 2023
…b#14839) * [mqtt.homeassistant] support color temp on JSON schema lights also adds a color_mode channel if color temp is possible, so you can know how the bulb is behaving * put color mode channel construction into buildChannels() --------- Signed-off-by: Cody Cutrer <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Nov 26, 2023
Due to openhab#15427 and openhab#14839 being developed independently, but merged to main successively Signed-off-by: Cody Cutrer <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…b#14839) * [mqtt.homeassistant] support color temp on JSON schema lights also adds a color_mode channel if color temp is possible, so you can know how the bulb is behaving * put color mode channel construction into buildChannels() --------- Signed-off-by: Cody Cutrer <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
Due to openhab#15427 and openhab#14839 being developed independently, but merged to main successively Signed-off-by: Cody Cutrer <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adds a color_mode channel if color temp is possible, so you can know how the bulb is behaving